Don't create new scratch VHD per image for CimFS#9659
Conversation
|
Hi @ambarve. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d22732e to
38e490b
Compare
go.mod
Outdated
| sigs.k8s.io/yaml v1.3.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/Microsoft/hcsshim => github.com/ambarve/hcsshim v0.9.1-0.20240118174743-ed3de0e40cae |
There was a problem hiding this comment.
Is there a pending PR/change on hcsshim that this PR is dependent on?
There was a problem hiding this comment.
Yeah that PR is here: microsoft/hcsshim#2002
38e490b to
1101544
Compare
|
LGTM! |
|
@fuweid @thaJeztah could you please take a look at this PR when you have some time? Thanks! |
1101544 to
66f9c28
Compare
fuweid
left a comment
There was a problem hiding this comment.
Just left one question and it looks good to me if there is rollback progress.
79a8857 to
0a74313
Compare
CimFS layers don't need to create a new scratch VHD per image. The scratch VHDs used with CimFS are empty so we can just create one base VHD and one differencing VHD and copy it for every scratch snapshot. (Note that UVM VHDs are still unique per image because the VHD information is embedded in the UVM BCD during import) Signed-off-by: Amit Barve <ambarve@microsoft.com>
|
ping @kiashok |
signed off! Could you merge the PR? :) |
|
@kiashok yes! merged~ |
CimFS layers don't need to create a new scratch VHD per image. The scratch VHDs used with CimFS are empty so we can just create one VHD and copy it for every scratch snapshot. (Note that UVM VHDs are still unique per image because the VHD information is embedded in the UVM BCD during import)