sandbox: fix podsandbox recover status issue #9644
Conversation
|
Hi @abel-von. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9d6ac0e to
6e8aa66
Compare
fuweid
left a comment
There was a problem hiding this comment.
Would you please add e2e test for this?
Thanks
|
/ok-to-test |
1ee381f to
ebc2fbb
Compare
some ut and e2e tests are added, please take a look, @fuweid |
ebc2fbb to
b28eeb9
Compare
|
/retest |
b28eeb9 to
6e8aa66
Compare
f817655 to
1acfc3c
Compare
|
/test pull-containerd-node-e2e |
|
wave.. generally e2e is a test in the k8s buckets.. but should be good enough for now to do integration here and open issue to add a test in node-e2e |
@abel-von looks like changes require rebase. |
We can't set the status to Ready before task.Wait succeed. Signed-off-by: Abel Feng <fshb1988@gmail.com>
Signed-off-by: Abel Feng <fshb1988@gmail.com>
1acfc3c to
e230ed9
Compare
|
Done rebased, but a CI error in fedora and it seems a network problem. please take a look @mxpv |
fuweid
left a comment
There was a problem hiding this comment.
LGTM
Let's handle the comment in the follow-up.
| waitCh <- struct{}{} | ||
| }() | ||
| t.Logf("Create a sandbox with shim create delay") | ||
| _, err = runtimeService.RunPodSandbox(sbUnknownConfig, failpointRuntimeHandler) |
There was a problem hiding this comment.
It might be flaky if the RunPodSandbox is called after restar containerd.
We can't set the status to Ready before task.Wait succeed.
#9463 (comment)