[release/1.7 backport] import/export: Support references to missing content #9600
[release/1.7 backport] import/export: Support references to missing content #9600mxpv merged 5 commits intocontainerd:release/1.7from
Conversation
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com> (cherry picked from commit 377c5ca) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Allow importing/exporting archives which doesn't have all the referenced blobs. This allows to export/import an image with only some of the platforms available locally while still persisting the full index. > The blobs directory MAY be missing referenced blobs, in which case the missing blobs SHOULD be fulfilled by an external blob store. https://github.com/opencontainers/image-spec/blob/v1.0/image-layout.md#blobs Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 61a7c49) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Persist manifest/indexes distribution source labels as annotations in the index.json. This could allow the importer to fetch the missing blobs from the external repository. These can't really be persisted directly in blob descriptors because that would alter the digests. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit b9af453) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
|
Hi @vvoland. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6578029 to
c8a5c13
Compare
|
@vvoland looks like something is failing in this branch; can you also check if the "cherry-picked from" commit-id's match the one from the PR against main? |
c8a5c13 to
39da4bc
Compare
Also refactor tests to use the t.Run and run each test concurrently in a separate namespace. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 0d3c3ef) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Don't make the `Export` signature more restrictive in a cherry-pick. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
39da4bc to
6089b05
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
whoop! looks like it's green now 🎉
LGTM
|
/cc @laurazard @cpuguy83 |
Allow importing/exporting archives which doesn't have all the referenced blobs.
This allows to export/import an image with only some of the platforms available locally while still persisting the full index.
https://github.com/opencontainers/image-spec/blob/v1.0/image-layout.md#blobs