sandbox: add event monitor for podsandbox controller #9598
Conversation
|
Hi @abel-von. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7dad049 to
5584f2d
Compare
|
needs to rebase after #9463 is merged |
5584f2d to
17fcb40
Compare
17fcb40 to
8119c10
Compare
8119c10 to
9aa178f
Compare
|
needs-rebase after #9617 is merged |
9aa178f to
ff34ee0
Compare
|
Will take a look in two days. Thanks! |
Signed-off-by: Abel Feng <fshb1988@gmail.com>
ff34ee0 to
d0da3d1
Compare
|
/ok-to-test |
|
@fuweid PTAL |
| c.eventMonitor.subscribe(c.client) | ||
| // note: filters are any match, if you want any match but not in namespace foo | ||
| // then you have to manually filter namespace foo | ||
| c.eventMonitor.Subscribe(c.client, []string{`topic=="/tasks/oom"`, `topic~="/images/"`}) |
There was a problem hiding this comment.
no idea why not just get events from k8s.io namespace.
if there is no regression issue, I would like add namespace filter in here (follow-up)
There was a problem hiding this comment.
@fuweid was annoyed by hundreds (ok thousands) of these filling my screen:
DEBU[2025-04-17T20:33:22.454388241Z] Received containerd event timestamp - 2025-04-17 20:33:22.45412799 +0000 UTC, namespace - "moby", topic - "/tasks/exit"
DEBU[2025-04-17T20:33:22.454512450Z] Ignoring events in namespace - "moby"
did the blame found this PR :-) definitely can't fathom why we subs for all namespaces... :-)
There was a problem hiding this comment.
I think so. ley me file pull request to fix it
|
/retest |
Currently the podsandbox controller has to get event monitor from CRI plugin, that makes the podsandbox controller dependent on the CRI plugin, this PR decouples it by create a event monitor for podsandbox controller independently.