Skip to content

Conversation

@abel-von
Copy link
Contributor

If the sandbox provides task API itself, shim management is not required anymore, and shimTask is no longer suitable for the task type provided by the sandbox. So I'm adding a "sandboxedTask" type here, and separating the two types can effectively reduce code complexity.

image

@k8s-ci-robot
Copy link

Hi @abel-von. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abel-von abel-von marked this pull request as draft December 25, 2023 03:43
@abel-von
Copy link
Contributor Author

@fuweid

and add some functions in client.Sandbox, and prefer using it to call
sandbox apis in CRI plugins

Signed-off-by: Abel Feng <fshb1988@gmail.com>
Signed-off-by: Abel Feng <fshb1988@gmail.com>
Signed-off-by: Abel Feng <fshb1988@gmail.com>
Signed-off-by: Abel Feng <fshb1988@gmail.com>
@k8s-ci-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims dims added the area/cri Container Runtime Interface (CRI) label Feb 10, 2024
@fuweid fuweid self-assigned this Feb 23, 2024
@fuweid fuweid added this to the 2.0 milestone Mar 15, 2024
@abel-von
Copy link
Contributor Author

The codes has been splitted into several PRs, close this one.

@abel-von abel-von closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants