Skip to content

[release 1.7] backport: fix on dialer function for windows#9501

Merged
samuelkarp merged 1 commit intocontainerd:release/1.7from
profnandaa:release_1_17_backport
Dec 19, 2023
Merged

[release 1.7] backport: fix on dialer function for windows#9501
samuelkarp merged 1 commit intocontainerd:release/1.7from
profnandaa:release_1_17_backport

Conversation

@profnandaa
Copy link
Contributor

@profnandaa profnandaa commented Dec 11, 2023

cherry-pick commit 8e91edb

Backport of #9412

@profnandaa
fix(pkg/dialer): minor fix on dialer function for windows
68d2373 
This commit fixes the dialer function to make sure that
"npipe://" prefix is trimmed, just like the way it is done
in the Unix counterpart, `./dialer_unix.go:50`

This will also unblock some downstream work going on in
buildkit; setting up integration tests to run on Windows.

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
@k8s-ci-robot
Copy link

k8s-ci-robot commented Dec 11, 2023

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

k8s-ci-robot commented Dec 11, 2023

Hi @profnandaa. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@profnandaa profnandaa changed the base branch from main to release/1.7 December 11, 2023 19:17
@profnandaa profnandaa changed the title [release 1.7] backport: [release 1.7] backport: fix on dialer function for windows Dec 11, 2023
@profnandaa
Copy link
Contributor Author

profnandaa commented Dec 11, 2023

/cc. @gabriel-samfira

gabriel-samfira
gabriel-samfira approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@gabriel-samfira gabriel-samfira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@samuelkarp samuelkarp merged commit 679b52e into containerd:release/1.7 Dec 19, 2023
@profnandaa profnandaa deleted the release_1_17_backport branch December 20, 2023 04:18
@dmcgowan dmcgowan mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

+1 more reviewer

@gabriel-samfira gabriel-samfira gabriel-samfira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ok-to-test platform/windows Windows size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@profnandaa @k8s-ci-robot @dmcgowan @samuelkarp @gabriel-samfira