Skip to content

[release/1.7] Windows default path overwrite fix #9440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
Nov 30, 2023
Merged

[release/1.7] Windows default path overwrite fix #9440

dmcgowan merged 1 commit into from
Nov 30, 2023

Conversation

@CharityKathure
Copy link

@CharityKathure CharityKathure commented Nov 30, 2023

Windows Containers have a default path already configured at bootup. WithDefaultPathEnv overwrites this with a unix path

(cherry picked from commit 7d63690 without any additional changes)

Fix windows default path overwrite issue
31fe037 
Windows Containers have a default path already configured at bootup. WithDefaultPathEnv overwrites this with a unix path

Signed-off-by: charitykathure <kathurecharity505@gmail.com>
(cherry picked from commit 7d63690)
Signed-off-by: Charity Kathure <ckathure@microsoft.com>
@k8s-ci-robot
Copy link

k8s-ci-robot commented Nov 30, 2023

Hi @CharityKathure. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CharityKathure CharityKathure mentioned this pull request Nov 30, 2023
Closed
@kiashok
Copy link
Contributor

kiashok commented Nov 30, 2023 •
edited
Loading

@CharityKathure could you please include the release branch you are backporting the commit to in the title? Example:

[release/1.7] Fix windows default path overwrite issue

@CharityKathure CharityKathure changed the title Fix windows default path overwrite issue [release/1.7] Fix windows default path overwrite issue Nov 30, 2023
@kiashok
Copy link
Contributor

kiashok commented Nov 30, 2023

/ok-to-test

@CharityKathure CharityKathure changed the title [release/1.7] Fix windows default path overwrite issue [release/1.7] Windows default path overwrite fix Nov 30, 2023
@dmcgowan dmcgowan merged commit 9c65471 into containerd:release/1.7 Nov 30, 2023
@dmcgowan dmcgowan mentioned this pull request Dec 7, 2023
Merged
@mfahlandt mfahlandt mentioned this pull request Dec 12, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@kiashok kiashok kiashok approved these changes

Assignees

No one assigned

Labels

ok-to-test size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CharityKathure @k8s-ci-robot @kiashok @dmcgowan @estesp