Skip to content

sandbox: add cri integration test case for upgrade #9434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxpv merged 2 commits into from
Dec 1, 2023
Merged

sandbox: add cri integration test case for upgrade #9434

mxpv merged 2 commits into from
Dec 1, 2023

Conversation

@abel-von
Copy link
Contributor

@abel-von abel-von commented Nov 29, 2023

To make sure the compatibility when upgrade from 1.6-1.7, or 1.7-2.0, we add more test cases to manipulate the containers in the pod of old version.

and we add a commit to fix the compatibility issue. that when get runtime info of sandbox, we may have to downgrade to get it from sandbox container.

@k8s-ci-robot
Copy link

k8s-ci-robot commented Nov 29, 2023

Hi @abel-von. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abel-von abel-von mentioned this pull request Nov 29, 2023
Merged
@mikebrow
Copy link
Member

mikebrow commented Nov 29, 2023

/ok-to-test

@samuelkarp
Copy link
Member

samuelkarp commented Nov 29, 2023

/retest

@abel-von abel-von force-pushed the add-integration-test branch from cf49701 to c3660f9 Compare November 30, 2023 01:12
fuweid
fuweid approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just let comments on naming. Thanks!

@abel-von abel-von force-pushed the add-integration-test branch from c3660f9 to 658373b Compare December 1, 2023 07:41
@abel-von
upgrade: add cri upgrade test case
95d2a3b 
Signed-off-by: Abel Feng <fshb1988@gmail.com>
@abel-von
sandbox: get runtime info from sandbox or container
c036375 
For backward compatibility, we should get runtimeInfo from sandbox in
db, or get it from the sandbox container in db.
Note that this is a temporary solution and we will remove the Container field in
Sandbox in cri cache, and replace it with a SandboxInsantance of type
containerd.Sandbox interface.

Signed-off-by: Abel Feng <fshb1988@gmail.com>
@abel-von abel-von force-pushed the add-integration-test branch from 658373b to c036375 Compare December 1, 2023 07:58
@fuweid
Copy link
Member

fuweid commented Dec 1, 2023 

2023-12-01T08:19:20.9159990Z     default:     log_hook.go:47: time="2023-12-01T08:19:20.910589753Z" level=debug msg="event published" func="exchange.(*Exchange).Publish.func1" file="/root/go/src/github.com/containerd/containerd/events/exchange/exchange.go:114" ns=k8s.io testcase=TestCRIImagePullTimeout/SlowCommitWriter topic=/snapshot/remove type=containerd.events.SnapshotRemove
2023-12-01T08:19:20.9174466Z     default:     image_pull_timeout_test.go:98:
2023-12-01T08:19:20.9175778Z     default:         	Error Trace:	/root/go/src/github.com/containerd/containerd/integration/image_pull_timeout_test.go:98
2023-12-01T08:19:20.9177240Z     default:         	Error:      	Received unexpected error:
2023-12-01T08:19:20.9180446Z     default:         	            	failed to pull and unpack image "ghcr.io/containerd/volume-ownership:2.1": failed to extract layer sha256:b8a36d10656ac19ddb96ef3107f76820663717708fc37ce929925c36d1b1d157: mount callback failed on /run/user/1000/containerd-mount2267680058: failed call to UtimesNanoAt for /run/user/1000/containerd-mount2267680058/boot: no such file or directory: unknown

Hmm, never see this before.
REF: https://github.com/containerd/containerd/actions/runs/7057311878/job/19210825105?pr=9434

@mxpv mxpv added this pull request to the merge queue Dec 1, 2023
Merged via the queue into containerd:main with commit 63609d3 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

ok-to-test size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@abel-von @k8s-ci-robot @mikebrow @samuelkarp @fuweid @mxpv