Skip to content

[release/1.6] Add a new image label if it is docker schema 1 #9267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samuelkarp merged 1 commit into from
Oct 24, 2023
Merged

[release/1.6] Add a new image label if it is docker schema 1 #9267

samuelkarp merged 1 commit into from
Oct 24, 2023

Conversation

@qiutongs
Copy link
Contributor

@qiutongs qiutongs commented Oct 18, 2023

(cherry picked from commit 7712375)

PR in main #9215

@k8s-ci-robot
Copy link

k8s-ci-robot commented Oct 18, 2023

Hi @qiutongs. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiutongs
Copy link
Contributor Author

qiutongs commented Oct 18, 2023

/cc @samuelkarp @mikebrow @fuweid

@samuelkarp
Copy link
Member

samuelkarp commented Oct 18, 2023

/ok-to-test

@qiutongs qiutongs force-pushed the backport-schema1-label-1.6 branch from 19b62b1 to f2a43f7 Compare October 18, 2023 21:49
@qiutongs
Add a new image label if it is docker schema 1
8108f0d 
Signed-off-by: Qiutong Song <songqt01@gmail.com>
(cherry picked from commit 7712375)
Signed-off-by: Qiutong Song <songqt01@gmail.com>
@qiutongs qiutongs force-pushed the backport-schema1-label-1.6 branch from f2a43f7 to 8108f0d Compare October 18, 2023 21:56
@qiutongs
Copy link
Contributor Author

qiutongs commented Oct 18, 2023

/cc @henry118

@k8s-ci-robot k8s-ci-robot requested a review from henry118 October 18, 2023 21:59
henry118
henry118 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@henry118 henry118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR LGTM. Not sure why the tests failed, but seems unrelated to this change.

@samuelkarp samuelkarp merged commit bf6f562 into containerd:release/1.6 Oct 24, 2023
@qiutongs qiutongs deleted the backport-schema1-label-1.6 branch October 24, 2023 05:22
@akhilerm akhilerm mentioned this pull request Nov 19, 2023
Merged
@AkihiroSuda AkihiroSuda mentioned this pull request Feb 6, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@henry118 henry118 henry118 approved these changes

@fuweid fuweid Awaiting requested review from fuweid

@mikebrow mikebrow Awaiting requested review from mikebrow

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qiutongs @k8s-ci-robot @samuelkarp @henry118