Skip to content

[release/1.6] Allow for images with artifacts to pull#9150

Merged
kzys merged 1 commit intocontainerd:release/1.6from
jsturtevant:cherry-pick-9142-on-1-6
Oct 6, 2023
Merged

[release/1.6] Allow for images with artifacts to pull#9150
kzys merged 1 commit intocontainerd:release/1.6from
jsturtevant:cherry-pick-9142-on-1-6

Conversation

@jsturtevant
Copy link
Copy Markdown
Contributor

@jsturtevant jsturtevant commented Sep 26, 2023

(cherry picked from commit a9ba33f)

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Sep 26, 2023

Hi @jsturtevant. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Sep 26, 2023

/ok-to-test

@kiashok
Copy link
Copy Markdown
Contributor

kiashok commented Sep 28, 2023

@jsturtevant the test failure seems to be unrelated - should we rerun the test?

@jsturtevant jsturtevant force-pushed the cherry-pick-9142-on-1-6 branch from 9453ca4 to b50af1c Compare September 28, 2023 17:20
@jsturtevant
Allow for images with artifacts to pull
8066dd8 
Signed-off-by: James Sturtevant <jstur@microsoft.com>
(cherry picked from commit a9ba33f)
Signed-off-by: James Sturtevant <jstur@microsoft.com>
@jsturtevant jsturtevant force-pushed the cherry-pick-9142-on-1-6 branch from b50af1c to 8066dd8 Compare October 6, 2023 16:43
@jsturtevant jsturtevant mentioned this pull request Oct 6, 2023
Closed
@jsturtevant
Copy link
Copy Markdown
Contributor Author

jsturtevant commented Oct 6, 2023

looks like things are resolved on windows jobs

@mikebrow @dmcgowan PTAL

@kzys kzys merged commit 4845c1d into containerd:release/1.6 Oct 6, 2023
@jsturtevant jsturtevant mentioned this pull request Oct 10, 2023
Closed
@akhilerm akhilerm mentioned this pull request Nov 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@kiashok kiashok kiashok approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsturtevant @k8s-ci-robot @mikebrow @kiashok @kzys