Skip to content

[release/1.7] Allow for images with artifacts to pull#9149

Merged
dmcgowan merged 1 commit intocontainerd:release/1.7from
jsturtevant:cherry-pick-9142-on-1-7
Oct 6, 2023
Merged

[release/1.7] Allow for images with artifacts to pull#9149
dmcgowan merged 1 commit intocontainerd:release/1.7from
jsturtevant:cherry-pick-9142-on-1-7

Conversation

@jsturtevant
Copy link
Copy Markdown
Contributor

@jsturtevant jsturtevant commented Sep 26, 2023

(cherry picked from commit a9ba33f)

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Sep 26, 2023

Hi @jsturtevant. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Sep 26, 2023

/ok-to-test

mikebrow
mikebrow approved these changes Sep 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Sep 27, 2023

The windows binaries builds seem to be broken in this branch. We'll probably have to hold merges in this branch until that gets resolved.

@kiashok
Copy link
Copy Markdown
Contributor

kiashok commented Sep 28, 2023

The windows binaries builds seem to be broken in this branch. We'll probably have to hold merges in this branch until that gets resolved.

Hi @dmcgowan , do you know if someone actively taking a look at this? Otherwise I could help

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Sep 28, 2023

@kiashok I don't know of anyone looking at it yet. @akhilerm had a suggestion of trying to downgrade mingw but warned it might be slow down CI.

@jsturtevant jsturtevant force-pushed the cherry-pick-9142-on-1-7 branch from 99e3811 to 27e4121 Compare October 6, 2023 16:43
@jsturtevant jsturtevant mentioned this pull request Oct 6, 2023
Closed
@jsturtevant
Copy link
Copy Markdown
Contributor Author

jsturtevant commented Oct 6, 2023

looks like things have been resolved on the Windows side. I don't believe the integration test failure is related.

@jsturtevant
Allow for images with artifacts to pull
6ca0aeb 
Signed-off-by: James Sturtevant <jstur@microsoft.com>
(cherry picked from commit a9ba33f)
Signed-off-by: James Sturtevant <jstur@microsoft.com>
@jsturtevant jsturtevant force-pushed the cherry-pick-9142-on-1-7 branch from 27e4121 to 6ca0aeb Compare October 6, 2023 17:43
@jsturtevant
Copy link
Copy Markdown
Contributor Author

jsturtevant commented Oct 6, 2023

@dmcgowan @mikebrow Looks like are good on CI. Thanks!

@dmcgowan dmcgowan merged commit 8664fca into containerd:release/1.7 Oct 6, 2023
@jsturtevant jsturtevant mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsturtevant @k8s-ci-robot @mikebrow @dmcgowan @kiashok