Skip to content

vendor: github.com/containerd/nri v0.5.0#9091

Merged
estesp merged 1 commit intocontainerd:mainfrom
thaJeztah:update_nri
Sep 18, 2023
Merged

vendor: github.com/containerd/nri v0.5.0#9091
estesp merged 1 commit intocontainerd:mainfrom
thaJeztah:update_nri

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Sep 13, 2023 •
edited
Loading

This version no longer has a dependency on containerd, cutting down the number of circular dependencies.

full diff: containerd/nri@v0.4.0...v0.5.0

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Sep 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@thaJeztah thaJeztah mentioned this pull request Sep 13, 2023
Merged
@thaJeztah thaJeztah force-pushed the update_nri branch 4 times, most recently from 73e14bc to f05dd44 Compare September 15, 2023 17:09
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Sep 15, 2023

@samuelkarp @mikebrow everything looks happy here as well; if we do a new tag of containerd/nri, I can update this PR, and move it out of draft 👍

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Sep 15, 2023

Looks good, tagged https://github.com/containerd/nri/releases/tag/v0.5.0

@thaJeztah
vendor: github.com/containerd/nri v0.5.0
8cbb4ea 
This version no longer has a dependency on containerd, cutting
down the number of circular dependencies.

full diff: containerd/nri@v0.4.0...v0.5.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title [WIP] vendor: update github.com/containerd/nri@latest vendor: github.com/containerd/nri v0.5.0 Sep 16, 2023
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Sep 16, 2023

Thanks! Updated to use the tag, and moved it out of draft

@thaJeztah thaJeztah marked this pull request as ready for review September 16, 2023 08:43
@thaJeztah thaJeztah added the cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch label Sep 16, 2023
@thaJeztah thaJeztah mentioned this pull request Sep 17, 2023
Merged
@estesp estesp merged commit 82df7d5 into containerd:main Sep 18, 2023
@thaJeztah thaJeztah deleted the update_nri branch September 18, 2023 20:38
@austinvazquez austinvazquez added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah @k8s-ci-robot @dmcgowan @samuelkarp @estesp @austinvazquez