replace reference/docker for github.com/distribution/reference v0.5.0 #9034
Conversation
|
Skipping CI for Draft Pull Request. |
The reference/docker package was a fork of github.com/distribution/distribution, which could not easily be used as a direct dependency, as it brought many other dependencies with it. The "reference' package has now moved to a separate repository, which means we can replace the local fork, and use the upstream implementation again. The new module was extracted from the distribution repository at commit: distribution/distribution@b9b1940 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
7d8fd25 to
4923470
Compare
|
A first (v0.5.0) release of the module was done, so this should be ready for prime-time now. Given that the module is (see git move) an edit: forgot that containerd didn't have the latest changes; there are some diffs, so worth looking at when deciding |
|
By +1 from me. Will check if any reviewers have picked this up or not in a few days. |
|
+1 for taking this in
@thaJeztah I didn't see any recent changes, at least functional, just test and repository management changes. You have specific changes in mind we would need to consider? |
|
We can keep the deprecated markers for this PR, but think we could just ditch the package entirely for v2 |
Yes, correct, there should be no functional changes But I wrote "clean move", and then realise: no, I'm lying!". Didn't want to sweep those changes under the rug 😅 |
The reference/docker package was a fork of github.com/distribution/distribution, which could not easily be used as a direct dependency, as it brought many other dependencies with it.
The "reference' package has now moved to a separate repository, which means we can replace the local fork, and use the upstream implementation again.
The "reference" package was moved to a separate module, which was extracted from distribution/distribution@b9b1940