Skip to content

[release/1.7] Check hcsshim tag dependencies#8976

Closed
kiashok wants to merge 1 commit intocontainerd:release/1.7from
kiashok:checkHcsshimDependencies
Closed

[release/1.7] Check hcsshim tag dependencies#8976
kiashok wants to merge 1 commit intocontainerd:release/1.7from
kiashok:checkHcsshimDependencies

Conversation

@kiashok
Copy link
Copy Markdown
Contributor

@kiashok kiashok commented Aug 16, 2023

This PR is for testing some changes made on hcsshim to get rid of some dependencies while vendoring hcsshim tags into containerd/1.7

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 16, 2023

Hi @kiashok. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kiashok kiashok force-pushed the checkHcsshimDependencies branch 2 times, most recently from 9f63e26 to f596810 Compare August 17, 2023 17:56
@kiashok
Update hcsshim tag v0.10.0-rc.8 to reduce dependencies while vendoring
2aeb2ce 
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@kiashok kiashok force-pushed the checkHcsshimDependencies branch from f596810 to 2aeb2ce Compare August 17, 2023 17:59
@kiashok kiashok mentioned this pull request Aug 17, 2023
Closed
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Aug 24, 2023

Can we get this PR rebased and ready. Its a prerequisite for the other hcsshim change?

@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Aug 24, 2023

Can we get this PR rebased and ready. Its a prerequisite for the other hcsshim change?

Hi @dmcgowan , I drafted this PR to get more thoughts on the feedback and conversations happening here #8903. I think the idea is folks do not like the number of changed being brought in by hcsshim tag update in containerd/1.7 esp to protobuf etc. Could you please share your thoughts?

@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 31, 2023

Given the work in main to move to a v0.12 tag vendor for hcsshim, I assume this PR is no longer necessary?

@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Aug 31, 2023

Given the work in main to move to a v0.12 tag vendor for hcsshim, I assume this PR is no longer necessary?

Right, I'll close it. I'll be updating #8903 with the new tag for hcsshim for containerd/1.7

@kiashok kiashok closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp Awaiting requested review from samuelkarp samuelkarp will be requested when the pull request is marked ready for review samuelkarp is a code owner

@chrishenzie chrishenzie Awaiting requested review from chrishenzie chrishenzie will be requested when the pull request is marked ready for review chrishenzie is a code owner

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kiashok @k8s-ci-robot @dmcgowan @estesp