Skip to content

Update hcsshim tag to v0.10.0#8940

Merged
AkihiroSuda merged 2 commits intocontainerd:mainfrom
kiashok:updateShimTag-main
Aug 10, 2023
Merged

Update hcsshim tag to v0.10.0#8940
AkihiroSuda merged 2 commits intocontainerd:mainfrom
kiashok:updateShimTag-main

Conversation

@kiashok
Copy link
Copy Markdown
Contributor

@kiashok kiashok commented Aug 9, 2023

Update hcsshim tag to v0.10.0 + go mod tidy/vendor and update dependencies after updating protobuf in hcsshim

kiashok added 2 commits August 9, 2023 11:55
@kiashok
Update hcsshim tag to v0.10.0
e7e5619 
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@kiashok
Update dependencies after protobuf update in hcsshim
a645ff2 
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
(cherry picked from commit d129b6f)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 9, 2023

Hi @kiashok. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kiashok kiashok mentioned this pull request Aug 9, 2023
Closed
@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Aug 9, 2023

@thaJeztah updating the hcsshim tag to v0.10.0 on main. Could you take a look when you have some time please? Thanks!

thaJeztah
thaJeztah approved these changes Aug 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Aug 9, 2023

@MikeZappa87 could you take a look when you have some time please? Thanks!

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Aug 9, 2023

/ok-to-test

@AkihiroSuda AkihiroSuda merged commit 70a2c95 into containerd:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@dcantah dcantah dcantah approved these changes

@MikeZappa87 MikeZappa87 MikeZappa87 approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kiashok @k8s-ci-robot @AkihiroSuda @thaJeztah @dcantah @MikeZappa87