Skip to content

[release/1.7 backport] oci: Use WithReadonlyTempMount when adding users/groups#8358

Merged
dmcgowan merged 1 commit intocontainerd:release/1.7from
thaJeztah:1.7_backport_oci_readonly_mounts
Apr 6, 2023
Merged

[release/1.7 backport] oci: Use WithReadonlyTempMount when adding users/groups#8358
dmcgowan merged 1 commit intocontainerd:release/1.7from
thaJeztah:1.7_backport_oci_readonly_mounts

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

(cherry picked from commit cab0562)


The #8259 change added a new WithReadonlyTempMount that will force the mount to be readonly.

This change removes the tryReadonlyMounts and uses that function.

Relates to #8259 Related: rumpl/moby#92 and moby/moby#45267

Note: once this PR is good to go I will backport these to 1.6 and 1.7, this is needed for moby's migration to the containerd image store and moby uses 1.6.x

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
(cherry picked from commit cab0562)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title [release/1.7] oci: Use WithReadonlyTempMount when adding users/groups [release/1.7 backport] oci: Use WithReadonlyTempMount when adding users/groups Apr 5, 2023
@thaJeztah
Copy link
Copy Markdown
Member Author

/retest

@thaJeztah
Copy link
Copy Markdown
Member Author

whoop, all green now 🎉

@dmcgowan dmcgowan merged commit d945322 into containerd:release/1.7 Apr 6, 2023
@thaJeztah thaJeztah deleted the 1.7_backport_oci_readonly_mounts branch April 6, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants