Register imagePullThroughput and count with MiB by keloyang · Pull Request #8337 · containerd/containerd

keloyang · 2023-03-31T08:57:03Z

No description provided.

k8s-ci-robot · 2023-03-31T08:57:13Z

Hi @keloyang. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Iceber · 2023-03-31T09:38:51Z

lgtm, cri/sbserver also needs to be modified. https://github.com/containerd/containerd/blob/main/pkg/cri/sbserver/metrics.go

/cc @pacoxu

k8s-ci-robot · 2023-03-31T09:38:53Z

@Iceber: GitHub didn't allow me to request PR reviews from the following users: pacoxu.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

you also need to modify the cri/sbserver https://github.com/containerd/containerd/blob/main/pkg/cri/sbserver/metrics.go

/cc @pacoxu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ruiwen-zhao · 2023-03-31T23:04:52Z

since we are on this, should we update the comment here to something like "image size in MB / image pull duration in seconds" ?

containerd/pkg/cri/server/metrics.go

Lines 45 to 46 in d92da14

    
           //  pull duration / (image size / 1MBi) 
        
           imagePullThroughput prom.Histogram

otherwise /lgtm

pacoxu · 2023-04-03T01:59:48Z

It was added in #7313 and probably, and we should cherry-pick it to 1.7.

keloyang · 2023-04-03T02:20:35Z

@Iceber @pacoxu I have added the same change to sbserver and modified the comments. PTAL， thanks for your review.

pkg/cri/sbserver/images/image_pull.go

pkg/cri/server/metrics.go

pkg/cri/sbserver/images/metrics.go

pacoxu

https://github.com/containerd/containerd/actions/runs/4593622478/jobs/8111799493?pr=8337#step:15:43 the CI failure seems to be unrelated.

=== FAIL: . TestRestartMonitor/Failure_Policy (0.13s)
    log_hook.go:47: time="2023-04-03T06:50:38.475123116Z" level=debug msg="remote introspection plugin filters" func="introspection.(*introspectionRemote).Plugins" file="/home/runner/work/containerd/containerd/services/introspection/introspection.go:46" filters="[type==io.containerd.snapshotter.v1, id==overlayfs]" testcase=TestRestartMonitor/Failure_Policy
    restart_monitor_test.go:420: expected restart count to be 1, got 0
    --- FAIL: TestRestartMonitor/Failure_Policy (0.13s)

keloyang · 2023-04-06T02:16:16Z

ping @Iceber @pacoxu PTAL.

pacoxu · 2023-04-06T02:35:02Z

/lgtm
/cc @samuelkarp @ruiwen-zhao

k8s-ci-robot · 2023-04-06T02:35:04Z

@pacoxu: GitHub didn't allow me to request PR reviews from the following users: ruiwen-zhao.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/lgtm
/cc @samuelkarp @ruiwen-zhao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/cri/server/image_pull.go

Signed-off-by: Shukui Yang <yangshukui@bytedance.com>

Iceber

LGTM

keloyang · 2023-04-10T01:54:54Z

ping @pacoxu @samuelkarp PTAL, thanks.

pacoxu · 2023-04-10T02:13:49Z

Thanks, @keloyang for fixing my mistake in last pr #7313 that is imagePullThroughput metrics is not registered.
/cc @fuweid

And we should cherry-pick it to 1.7.

fuweid

LGTM

ialidzhikov · 2024-02-22T15:29:02Z

And we should cherry-pick it to 1.7.

I don't see this PR cherry-picked to the release-1.7 branch..

ialidzhikov · 2024-02-22T15:32:04Z

/cherry-pick release/1.7

k8s-infra-cherrypick-robot · 2024-02-22T15:32:13Z

@ialidzhikov: only containerd org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

Details

In response to this:

/cherry-pick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ialidzhikov · 2024-02-22T15:47:42Z

Hi folks,

I now created a manual cherry-pick: #9855.
Could you please help getting it in?

k8s-ci-robot added the needs-ok-to-test label Mar 31, 2023

keloyang force-pushed the imagePullThroughput branch 2 times, most recently from 1bd0a36 to 6c5caa2 Compare April 3, 2023 02:14

pacoxu reviewed Apr 3, 2023

View reviewed changes

pkg/cri/sbserver/images/image_pull.go Outdated Show resolved Hide resolved

keloyang force-pushed the imagePullThroughput branch from 6c5caa2 to b3d0528 Compare April 3, 2023 02:48

Iceber reviewed Apr 3, 2023

View reviewed changes

pkg/cri/server/metrics.go Show resolved Hide resolved

keloyang force-pushed the imagePullThroughput branch from b3d0528 to 02d94ca Compare April 3, 2023 05:11

pacoxu reviewed Apr 3, 2023

View reviewed changes

pkg/cri/sbserver/images/metrics.go Outdated Show resolved Hide resolved

keloyang force-pushed the imagePullThroughput branch from 02d94ca to c3ba864 Compare April 3, 2023 06:31

keloyang requested review from Iceber and pacoxu April 3, 2023 10:02

pacoxu approved these changes Apr 3, 2023

View reviewed changes

keloyang force-pushed the imagePullThroughput branch from c3ba864 to 3eab039 Compare April 3, 2023 11:10

keloyang requested a review from pacoxu April 6, 2023 02:13

k8s-ci-robot requested a review from samuelkarp April 6, 2023 02:35

Iceber reviewed Apr 6, 2023

View reviewed changes

pkg/cri/server/image_pull.go Outdated Show resolved Hide resolved

Register imagePullThroughput and count with MiB

db22327

Signed-off-by: Shukui Yang <yangshukui@bytedance.com>

keloyang force-pushed the imagePullThroughput branch from 3eab039 to db22327 Compare April 7, 2023 02:12

keloyang requested a review from Iceber April 7, 2023 02:17

Iceber approved these changes Apr 7, 2023

View reviewed changes

pacoxu approved these changes Apr 10, 2023

View reviewed changes

k8s-ci-robot requested a review from fuweid April 10, 2023 02:13

fuweid approved these changes Apr 11, 2023

View reviewed changes

fuweid added the cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch label Apr 11, 2023

dcantah approved these changes Apr 12, 2023

View reviewed changes

dmcgowan approved these changes May 2, 2023

View reviewed changes

dmcgowan merged commit a7ceac8 into containerd:main May 2, 2023

ialidzhikov mentioned this pull request Feb 22, 2024

[release/1.7] Register imagePullThroughput and count with MiB #9855

Merged

ialidzhikov mentioned this pull request Feb 22, 2024

Getting gardener-extension-registry-cache production ready gardener/gardener-extension-registry-cache#3

Closed

96 tasks

austinvazquez added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Nov 20, 2024

Conversation

keloyang commented Mar 31, 2023

Uh oh!

k8s-ci-robot commented Mar 31, 2023

Uh oh!

Iceber commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 31, 2023

Uh oh!

ruiwen-zhao commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pacoxu commented Apr 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keloyang commented Apr 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pacoxu left a comment

Choose a reason for hiding this comment

Uh oh!

keloyang commented Apr 6, 2023

Uh oh!

pacoxu commented Apr 6, 2023

Uh oh!

k8s-ci-robot commented Apr 6, 2023

Uh oh!

Uh oh!

Iceber left a comment

Choose a reason for hiding this comment

Uh oh!

keloyang commented Apr 10, 2023

Uh oh!

pacoxu commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fuweid left a comment

Choose a reason for hiding this comment

Uh oh!

ialidzhikov commented Feb 22, 2024

Uh oh!

ialidzhikov commented Feb 22, 2024

Uh oh!

k8s-infra-cherrypick-robot commented Feb 22, 2024

Uh oh!

ialidzhikov commented Feb 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Iceber commented Mar 31, 2023 •

edited

Loading

ruiwen-zhao commented Mar 31, 2023 •

edited

Loading

pacoxu commented Apr 3, 2023 •

edited

Loading

pacoxu commented Apr 10, 2023 •

edited

Loading