Update release process after 1.7 by dmcgowan · Pull Request #8250 · containerd/containerd

dmcgowan · 2023-03-10T20:01:02Z

Retrospective changes based on our current release process followed for 1.7.0

thaJeztah · 2023-03-10T20:11:27Z

-   3. Check CI has completed and uploaded the binaries. Remove any binaries which get
-      uploaded but are not intended as part of the release (e.g. Darwin binaries).
+   3. Check the Github release, ensure the content matches what is expected and all the
+      release bianries are included.


typo

Suggested change

release bianries are included.

release binaries are included.

thaJeztah · 2023-03-10T20:12:19Z

-      when the binaries are pushed.
+   2. Verify release job has started in the actions tab and wait for release job to complete
+      successfully. If the job fails, attempt to restart it. If the job continuously fails,
+      delete the tag from Github as soon as possible and fix the issue before restarting the


Suggested change

delete the tag from Github as soon as possible and fix the issue before restarting the

delete the tag from GitHub as soon as possible and fix the issue before restarting the

I don't think we should delete the tag; once it's tagged, it's done; go module proxies may already have it stored, and will mark the module as invalid.

The correct step here would be to do a new release and retract the old one.

The alternative would be to tag at the end of the release (after validating). I know we do so for moby (once we're happy with a build, the commit is "blessed" by tagging it). But I guess that's a more extensive change in process

Yeah, that would be a bit more involved. When there is changes to the process or something large, we can test the release process on a fork. Deleting a tag is not ideal but it is the best solution if the tag is bad for some reason, the caching can get resolved.

thaJeztah · 2023-03-10T20:20:21Z

-   2. Create the Github release using the `Tag version` which was just pushed. Use the first
-      line outputted from the release tool as the `Release title` and the remainder of the
-      output for the description. No alteration of the release output should be needed.
-      Ensure `pre-release` is checked if an `-rc`.


I notice this was removed (ensure pre-release is checked); was there a reason to remove it?

(Or did GitHub fix this to do it automatically based on version now?)

GitHub CI does it for us automatically. We do not manually create the releases anymore.

samuelkarp · 2023-03-13T04:51:20Z

   2. Update the version file at `https://github.com/containerd/containerd/blob/main/version/version.go`

-   3. Update RELEASES.md to refer to the new release and dates.
+   3. (minor release only) Update RELEASES.md to refer to the new release and dates.


This should probably be major (like 2.0.0) and minor (1.7.0).

samuelkarp · 2023-03-13T04:52:24Z

+      release binaries are included.

-4. Update [`config.toml`](https://github.com/containerd/containerd.io/blob/f827d53826a426cb48f24cc08e43cc8722ad6d01/config.toml#L35) with latest release in the [containerd/containerd.io project](https://github.com/containerd/containerd.io); open PR to
+4. (minor release only) Create `release/x.y` branch from tag and push to `git@github.com:containerd/containerd.git`.


Major and minor?

I would say .0.0 releases are still minor releases

Wouldn't 2.0.0 be considered a major release? We'll still want a release/2.0 branch too.

samuelkarp · 2023-03-13T04:52:33Z

+
+5. (patch release only) Update RELEASES.md in main branch to refer to the new patch release.
+
+6. (minor release only) Create `cherry-pick/x.y.x` and `cherry-picked/x.y.x` labels


Major and minor?

Also, I think cherry-pick/x.y/cherry-picked/x.y since the z component will change with each patch.

samuelkarp · 2023-03-13T04:53:57Z

+
+7. Close any milestones associated with the release.
+
+8. Update [`config.toml`](https://github.com/containerd/containerd.io/blob/f827d53826a426cb48f24cc08e43cc8722ad6d01/config.toml#L35) with latest release in the [containerd/containerd.io project](https://github.com/containerd/containerd.io); open PR to


Should this point to a specific commit tree or to main?

Its not a good idea to use line numbers in the link when pointing to a branch. Could remove the line number and describe the update more.

AkihiroSuda · 2023-03-14T05:04:42Z

-   3. Check CI has completed and uploaded the binaries. Remove any binaries which get
-      uploaded but are not intended as part of the release (e.g. Darwin binaries).
+   3. Check the Github release, ensure the content matches what is expected and all the
+      release binaries are included.


Could you consider signing binaries? (for >= 2.0)
https://github.com/containerd/nerdctl/pull/2089/files#diff-ed933e266827bac3e1788519c912361cfaa862541ab38663e867b0a3978c34ca

Definitely could consider it. The focus of this PR is how it has been done for existing releases. We can add to the process then update this doc. What is pointed to there is a bit complicated and probably something we should try and automate from the dev end (maybe in release tool?)

We can try it for the 2.0 beta releases first, and if it works out we can update this doc. I don't want to add steps we haven't actually done in a release yet.

Signed-off-by: Derek McGowan <derek@mcg.dev>

Mention use of pull request labels Signed-off-by: Derek McGowan <derek@mcg.dev>

dmcgowan · 2024-04-24T18:28:37Z

Updated to address Sam's comment and added a commit related to changes in the release tool.

I would like to get the release signing as part of it but first we need some updates to our Github actions, we need to publish as a draft, output the built shasums for comparison, and either create a single shasum file or add functionality to the release tool to download, sign, and upload all the current shasums. It would be way too much work and error prone to individually sign the 21 sha sum files we create today.

dmcgowan · 2024-04-24T19:45:07Z

/retest

dmcgowan · 2024-04-30T15:18:44Z

/retest

samuelkarp · 2026-04-14T19:13:24Z

/cherry-pick release/1.7

(Cherry picking this over so LLM agents helping with releases have accurate instructions)

k8s-infra-cherrypick-robot · 2026-04-14T19:14:14Z

@samuelkarp: new pull request created: #13236

Details

In response to this:

/cherry-pick release/1.7

(Cherry picking this over so LLM agents helping with releases have accurate instructions)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

thaJeztah reviewed Mar 10, 2023

View reviewed changes

dmcgowan force-pushed the update-release-process branch from 0d4e4db to aff9d5d Compare March 10, 2023 20:36

samuelkarp reviewed Mar 13, 2023

View reviewed changes

AkihiroSuda reviewed Mar 14, 2023

View reviewed changes

AkihiroSuda approved these changes Mar 15, 2023

View reviewed changes

dmcgowan added 2 commits April 24, 2024 10:17

Update release process after 1.7

53c9e6f

Signed-off-by: Derek McGowan <derek@mcg.dev>

Update for latest updates to release tool

dfdfa20

Mention use of pull request labels Signed-off-by: Derek McGowan <derek@mcg.dev>

dmcgowan force-pushed the update-release-process branch from aff9d5d to dfdfa20 Compare April 24, 2024 18:23

k8s-ci-robot added the size/M label Apr 24, 2024

dmcgowan requested a review from samuelkarp April 24, 2024 18:28

samuelkarp approved these changes Apr 24, 2024

View reviewed changes

samuelkarp added this pull request to the merge queue Apr 30, 2024

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024

samuelkarp added this pull request to the merge queue Apr 30, 2024

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024

mxpv approved these changes Apr 30, 2024

View reviewed changes

mxpv added this pull request to the merge queue Apr 30, 2024

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024

mxpv added this pull request to the merge queue Apr 30, 2024

Merged via the queue into containerd:main with commit 97ea691 Apr 30, 2024

k8s-infra-cherrypick-robot mentioned this pull request Apr 14, 2026

[release/1.7] Update release process after 1.7 #13236

Merged

	release bianries are included.
	release binaries are included.

	delete the tag from Github as soon as possible and fix the issue before restarting the
	delete the tag from GitHub as soon as possible and fix the issue before restarting the


		5. (patch release only) Update RELEASES.md in main branch to refer to the new patch release.

		6. (minor release only) Create `cherry-pick/x.y.x` and `cherry-picked/x.y.x` labels


		7. Close any milestones associated with the release.

		8. Update [`config.toml`](https://github.com/containerd/containerd.io/blob/f827d53826a426cb48f24cc08e43cc8722ad6d01/config.toml#L35) with latest release in the [containerd/containerd.io project](https://github.com/containerd/containerd.io); open PR to

Conversation

dmcgowan commented Mar 10, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmcgowan commented Apr 24, 2024

Uh oh!

dmcgowan commented Apr 24, 2024

Uh oh!

dmcgowan commented Apr 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samuelkarp commented Apr 14, 2026

Uh oh!

k8s-infra-cherrypick-robot commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants