labels: Add LabelDistributionSource#8224
Conversation
|
Hi @vvoland. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@AkihiroSuda ptal (related to moby/moby#44963 (comment)) |
labels/labels.go
Outdated
| const LabelSharedNamespace = "containerd.io/namespace.shareable" | ||
|
|
||
| // LabelDistributionSource is added to content to reference the source | ||
| // repository it was obtained from. |
There was a problem hiding this comment.
"source repository" can be misinterpreted as a source code repository on VCS
There was a problem hiding this comment.
// LabelDistributionSource is added to content to indicate its origin.
// e.g., "containerd.io/distribution.source.docker.io=library/redis"Add a public const for "containerd.io/distribution.source" in `labels` package and replace hardcoded usages. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
be8230b to
dd3eedf
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
still LGTM
looks like this one is ready to be merged?
Add a public const for "containerd.io/distribution.source" in
labelspackage and replace hardcoded usages.