Skip to content

fatal error: concurrent map iteration and map write#7805

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
chaunceyjiang:painc
Dec 13, 2022
Merged

fatal error: concurrent map iteration and map write#7805
dmcgowan merged 1 commit intocontainerd:mainfrom
chaunceyjiang:painc

Conversation

@chaunceyjiang
Copy link
Contributor

@chaunceyjiang chaunceyjiang commented Dec 13, 2022

fix #7797

@chaunceyjiang
fatal error: concurrent map iteration and map write
5a3a9ba 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@k8s-ci-robot
Copy link

k8s-ci-robot commented Dec 13, 2022

Hi @chaunceyjiang. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kzys
kzys approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@kzys kzys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We are using %p against conn in other functions already.

@dmcgowan dmcgowan merged commit c666147 into containerd:main Dec 13, 2022
@haslersn
Copy link
Contributor

haslersn commented Dec 14, 2022

How does this fix the crash in #7797?

@dmcgowan dmcgowan mentioned this pull request Dec 14, 2022
Merged
@dmcgowan dmcgowan added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.6.x labels Dec 14, 2022
@dmcgowan
Copy link
Member

dmcgowan commented Dec 14, 2022

@haslersn according to the stack trace the formatter is what causes the call to the iterator, %p will not call the conn formatter. This change will go out in 1.6.13. Feel free to re-open if still getting a crash. Thank you for including the stack trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

containerd 1.6.12 crash with fatal error: concurrent map iteration and map write

5 participants

@chaunceyjiang @k8s-ci-robot @haslersn @dmcgowan @kzys