Change PushContent to require only Provider#7763
Merged
fuweid merged 1 commit intocontainerd:mainfrom Dec 7, 2022
Merged
Conversation
Before this required a full content.Store so that it could annotate distribution sources. With this change PushContent can be used with just a content.Provider. If the content.Provider is also a content.Manager then distribution sources will be updated accordingly. This allows people to use this function with a significantly implementation. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
dmcgowan
approved these changes
Dec 6, 2022
Member
dmcgowan
left a comment
There was a problem hiding this comment.
LGTM
I don't expect this to be a backwards compatibility problem since Provider is a subset interface of Store
| platformFilterhandler := images.FilterPlatforms(images.ChildrenHandler(store), platform) | ||
|
|
||
| annotateHandler := annotateDistributionSourceHandler(platformFilterhandler, store) | ||
| var handler images.Handler |
Member
There was a problem hiding this comment.
This could be cleaner if it just overwrote the same handler variable and var handler images.handler only needs a single path like before.
samuelkarp
approved these changes
Dec 7, 2022
fuweid
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this required a full content.Store so that it could annotate distribution sources.
With this change PushContent can be used with just a content.Provider. If the content.Provider is also a content.Manager then distribution sources will be updated accordingly.
This allows people to use this function with a significantly implementation.
I was trying to use remotes.PushContent to implement push directly from an OCI tarball only to realize this wants the full content.Store which I had no interest in implementing for a read-only tarball.