Skip to content

Add unit test to Opentelemetry tracing #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kzys merged 1 commit into from
Dec 7, 2022
Merged

Add unit test to Opentelemetry tracing #7671

kzys merged 1 commit into from
Dec 7, 2022

Conversation

@fangn2
Copy link
Contributor

@fangn2 fangn2 commented Nov 15, 2022 •
edited
Loading

Add unit tests to NewExporter and NewTracer for opentelemetry tracing support
The unit tests feed input of different combination of the cfg, then check the expected output
This PR is part of issue 7493
Signed-off-by: Tony Fang nenghui.fang@gmail.com

Unit test ran locally:

$ go test -v -run TestNewExporter
=== RUN   TestNewExporter
=== RUN   TestNewExporter/Test_http/protobuf_protocol,_expect_no_error
    otlp_test.go:72: input: {http://localhost:4318 http/protobuf false}
    otlp_test.go:76: output: <nil>
=== RUN   TestNewExporter/Test_invalid_endpoint,_expect_ErrInvalidArgument_error
    otlp_test.go:72: input: {http://localhost
        :4318 http/protobuf false}
    otlp_test.go:76: output: OpenTelemetry endpoint "http://localhost\n:4318" is invalid: invalid argument
=== RUN   TestNewExporter/Test_default_protocol,_expect_no_error
    otlp_test.go:72: input: {http://localhost:4318  false}
    otlp_test.go:76: output: <nil>
=== RUN   TestNewExporter/Test_grpc_protocol,_expect_no_error
    otlp_test.go:72: input: {http://localhost:4317 grpc false}
    otlp_test.go:76: output: <nil>
=== RUN   TestNewExporter/Test_http/json_protocol_which_is_not_supported,_expect_not_implemented_error
    otlp_test.go:72: input: {http://localhost:4318 http/json false}
    otlp_test.go:76: output: OpenTelemetry protocol "http/json" : not implemented
--- PASS: TestNewExporter (0.00s)
    --- PASS: TestNewExporter/Test_http/protobuf_protocol,_expect_no_error (0.00s)
    --- PASS: TestNewExporter/Test_invalid_endpoint,_expect_ErrInvalidArgument_error (0.00s)
    --- PASS: TestNewExporter/Test_default_protocol,_expect_no_error (0.00s)
    --- PASS: TestNewExporter/Test_grpc_protocol,_expect_no_error (0.00s)
    --- PASS: TestNewExporter/Test_http/json_protocol_which_is_not_supported,_expect_not_implemented_error (0.00s)
PASS
ok      github.com/containerd/containerd/tracing/plugin 0.006s


$ go test -v -run TestNewTracer
=== RUN   TestNewTracer
    otlp_test.go:101: config: &{containerd 1}
--- PASS: TestNewTracer (0.00s)
PASS
ok      github.com/containerd/containerd/tracing/plugin 0.006s

@k8s-ci-robot
Copy link

k8s-ci-robot commented Nov 15, 2022

Hi @fangn2. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kzys
kzys reviewed Nov 15, 2022
View reviewed changes
henry118
henry118 reviewed Nov 15, 2022
View reviewed changes
swagatbora90
swagatbora90 reviewed Nov 15, 2022
View reviewed changes
@fangn2 fangn2 force-pushed the adding-unit-test-for-opentelemetry-tracing branch 4 times, most recently from dba38e1 to bb67ebb Compare November 15, 2022 20:44
AkihiroSuda
AkihiroSuda reviewed Nov 15, 2022
View reviewed changes
@fangn2 fangn2 force-pushed the adding-unit-test-for-opentelemetry-tracing branch 4 times, most recently from 2b4928a to 09c1a6b Compare December 5, 2022 21:00
@fangn2 fangn2 changed the title Add unit test to NewExporter Add unit test to Opentelemetry tracing Dec 5, 2022
@fangn2 fangn2 marked this pull request as draft December 5, 2022 21:26
@fangn2 fangn2 closed this Dec 5, 2022
@fangn2 fangn2 force-pushed the adding-unit-test-for-opentelemetry-tracing branch from 73af0b1 to 6918432 Compare December 5, 2022 21:37
@fangn2 fangn2 reopened this Dec 5, 2022
@fangn2 fangn2 force-pushed the adding-unit-test-for-opentelemetry-tracing branch 2 times, most recently from e79aaa0 to 78463cc Compare December 5, 2022 22:50
@fangn2
Adding unit tests to opentelemetry tracing
8472946 
Refractor newExporter and newTracer, add unit tests to them
This PR is part of issue 7493

Signed-off-by: Tony Fang <nenghui.fang@gmail.com>
@fangn2 fangn2 force-pushed the adding-unit-test-for-opentelemetry-tracing branch from 78463cc to 8472946 Compare December 6, 2022 03:14
@fangn2 fangn2 marked this pull request as ready for review December 6, 2022 03:23
estesp
estesp approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swagatbora90
swagatbora90 reviewed Dec 6, 2022
View reviewed changes
@kzys kzys merged commit 62968d9 into containerd:main Dec 7, 2022
@fangn2 fangn2 mentioned this pull request Jan 31, 2023
Closed
@fangn2 fangn2 deleted the adding-unit-test-for-opentelemetry-tracing branch February 8, 2023 15:37
@vvoland vvoland mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henry118 henry118 henry118 left review comments

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+1 more reviewer

@swagatbora90 swagatbora90 swagatbora90 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fangn2 @k8s-ci-robot @kzys @estesp @henry118 @swagatbora90 @AkihiroSuda