Skip to content

images: support specifying SourceDateEpoch via ctx#7651

Merged
estesp merged 2 commits intocontainerd:mainfrom
AkihiroSuda:custom-image-createdat
Dec 12, 2022
Merged

images: support specifying SourceDateEpoch via ctx#7651
estesp merged 2 commits intocontainerd:mainfrom
AkihiroSuda:custom-image-createdat

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Nov 10, 2022

  1. epoch: propagate SOURCE_DATE_EPOCH via ctx
  2. images: support specifying SourceDateEpoch via ctx

For

@AkihiroSuda AkihiroSuda force-pushed the custom-image-createdat branch from ac67953 to 3a58217 Compare November 10, 2022 05:02
@AkihiroSuda AkihiroSuda marked this pull request as draft November 10, 2022 06:02
@AkihiroSuda
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e

1 similar comment
@AkihiroSuda
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e

@AkihiroSuda AkihiroSuda marked this pull request as ready for review November 10, 2022 22:47
@AkihiroSuda AkihiroSuda requested a review from dmcgowan November 15, 2022 22:49
@AkihiroSuda AkihiroSuda requested a review from dmcgowan November 21, 2022 17:50
@AkihiroSuda
Copy link
Copy Markdown
Member Author

@tonistiigi Does the current design LGTY?

@AkihiroSuda AkihiroSuda force-pushed the custom-image-createdat branch from 3a58217 to 0409cf3 Compare November 30, 2022 13:19
@AkihiroSuda AkihiroSuda changed the title images: support specifying SourceDateEpoch ; epoch: propagate SOURCE_DATE_EPOCH via ctx images: support specifying SourceDateEpoch via ctx Nov 30, 2022
@AkihiroSuda AkihiroSuda force-pushed the custom-image-createdat branch from 0409cf3 to 7402615 Compare November 30, 2022 13:27
@AkihiroSuda
Copy link
Copy Markdown
Member Author

@dmcgowan @tonistiigi Can we merge this, so that we can have this in the next RC of BuildKit? 🙏

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 133ddce into containerd:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants