[do not merge] test image-spec with embedded Platform#7382
Closed
thaJeztah wants to merge 1 commit intocontainerd:mainfrom
Closed
[do not merge] test image-spec with embedded Platform#7382thaJeztah wants to merge 1 commit intocontainerd:mainfrom
thaJeztah wants to merge 1 commit intocontainerd:mainfrom
Conversation
Member
thaJeztah
commented
Sep 8, 2022
- Testing the "embed_platform" branch from: Embed Platform in Image opencontainers/image-spec#949
- Relates to Fix several conversions of "ocispec.Image" to "ocispec.Platform" #7376 (comment)
|
Skipping CI for Draft Pull Request. |
0f0d0af to
5f0d079
Compare
Member
Author
|
Ah, yes, some changes needed if struct literals are used; |
Testing the "embed_platform" branch from: opencontainers/image-spec#949 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
5f0d079 to
ab663a7
Compare
tianon
reviewed
Oct 13, 2022
Comment on lines
+81
to
+83
| // FIXME: testing "embed_platform" branch from https://github.com/opencontainers/image-spec/pull/949 | ||
| replace github.com/opencontainers/image-spec => github.com/thaJeztah/image-spec v1.0.2-0.20220908165244-ca2e500b1693 | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| // FIXME: testing "embed_platform" branch from https://github.com/opencontainers/image-spec/pull/949 | |
| replace github.com/opencontainers/image-spec => github.com/thaJeztah/image-spec v1.0.2-0.20220908165244-ca2e500b1693 |
👀
Member
|
I've rolled the updated version of this change into #7376, so unless @thaJeztah objects to what I've done, this is probably safe to close 👀 |
Member
Author
|
superseded by #8498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.