release workflow: increase timeout to 30 minutes & remove Go setup action#7259
Merged
dmcgowan merged 2 commits intocontainerd:mainfrom Aug 5, 2022
Merged
release workflow: increase timeout to 30 minutes & remove Go setup action#7259dmcgowan merged 2 commits intocontainerd:mainfrom
dmcgowan merged 2 commits intocontainerd:mainfrom
Conversation
In the 1.6.7 release, we saw significantly longer execution time for producing builds that exceeded the previous timeout of 10 minutes, causing the workflow to fail. After increasing to 20 minutes in the release/1.6 branch, we continued to see one failure (which succeeded on retry). Increase to 30 minutes to provide additional buffer for the build to complete. Signed-off-by: Samuel Karp <samuelkarp@google.com>
Release builds are performed from within a Dockerfile-defined environment and do not require Go to be installed in the GitHub Actions runner environment. Signed-off-by: Samuel Karp <samuelkarp@google.com>
Member
|
Did a test run with this change https://github.com/dmcgowan/containerd/actions/runs/2805405593 Everything looks good, increasing the timeout makes sense since we don't want to have our release blocked if there is some gha weirdness slowing the builds down |
dmcgowan
approved these changes
Aug 5, 2022
This was referenced Aug 6, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the 1.6.7 release, we saw significantly longer execution time for producing builds that exceeded the previous timeout of 10 minutes, causing the workflow to fail. After increasing to 20 minutes in the release/1.6 branch, we continued to see one failure (which succeeded on retry).
Increase to 30 minutes to provide additional buffer for the build to complete.
Release builds are performed from within a Dockerfile-defined environment and do not require Go to be installed in the GitHub Actions runner environment.
See https://github.com/samuelkarp/containerd/actions/runs/2805142467 for a successful run.