Skip to content

chore: bump macos runner version#7206

Merged
fuweid merged 1 commit intocontainerd:mainfrom
renbaoshuo:patch-1
Jul 27, 2022
Merged

chore: bump macos runner version#7206
fuweid merged 1 commit intocontainerd:mainfrom
renbaoshuo:patch-1

Conversation

@renbaoshuo
Copy link
Contributor

@renbaoshuo renbaoshuo commented Jul 25, 2022

GitHub Action is sunsetting the macOS 10.15 Actions runner. It will stop working intermittently until being completely removed by 2022-8-30: https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22

@k8s-ci-robot
Copy link

k8s-ci-robot commented Jul 25, 2022

Hi @renbaoshuo. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estesp
estesp approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link
Member

cpuguy83 commented Jul 25, 2022

Looks like we have a dup with #7211

@mxpv
Copy link
Member

mxpv commented Jul 25, 2022

Sorry, I didn't notice this PR and opened a dup.
Differences - I think we should migrate to 12 (Monterey) which was released last year and update mac os tests job as well.

@renbaoshuo
Copy link
Contributor Author

renbaoshuo commented Jul 25, 2022

I've updated this PR and now it is using macOS 12 runner.

@renbaoshuo renbaoshuo mentioned this pull request Jul 25, 2022
Closed
@estesp
Copy link
Member

estesp commented Jul 26, 2022

Can you squash these commits? This only changes one file and should all be in a single commit.

@renbaoshuo
chore: bump macos runner version
f4d05f2 
GitHub Action is sunsetting the macOS 10.15 Actions runner. It will stop working intermittently until being completely removed by 2022-8-30: https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22

Signed-off-by: Baoshuo Ren <i@baoshuo.ren>
@renbaoshuo
Copy link
Contributor Author

renbaoshuo commented Jul 27, 2022

@estesp done.

estesp
estesp approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit f81b0e2 into containerd:main Jul 27, 2022
@renbaoshuo renbaoshuo deleted the patch-1 branch July 27, 2022 03:09
@estesp estesp mentioned this pull request Jul 29, 2022
Merged
@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.6.x labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@estesp estesp estesp approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@renbaoshuo @k8s-ci-robot @cpuguy83 @mxpv @estesp @fuweid @thaJeztah