Skip to content

Fix WWW-Authenticate parsing#7126

Merged
estesp merged 1 commit intocontainerd:mainfrom
kzys:fix-auth-param
Jul 5, 2022
Merged

Fix WWW-Authenticate parsing#7126
estesp merged 1 commit intocontainerd:mainfrom
kzys:fix-auth-param

Conversation

@kzys
Copy link
Member

@kzys kzys commented Jul 1, 2022

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

According to RFC 9110, quoted-string could be "".

https://datatracker.ietf.org/doc/html/rfc9110#section-11.6.1
https://datatracker.ietf.org/doc/html/rfc9110#appendix-A

Fixes containerd#6376.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@kzys kzys force-pushed the fix-auth-param branch from b8cd792 to 548c9c3 Compare July 1, 2022 20:27
@kzys kzys marked this pull request as ready for review July 1, 2022 20:28
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit c4b1b36 into containerd:main Jul 5, 2022
@kzys
Copy link
Member Author

kzys commented Jul 5, 2022

I will cherry-pick that to 1.5 and 1.6.

@kzys
Copy link
Member Author

kzys commented Jul 5, 2022

The cherry-pick PRs are #7131 (1.6) and #7132 (1.5).

@fuweid fuweid added cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.5.x labels Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to parse Www-Authenticate if auth-param has empty value

5 participants