Skip to content

add Vscode dir to git ignore #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pacoxu wants to merge 1 commit into from
Closed

add Vscode dir to git ignore #7002

pacoxu wants to merge 1 commit into from

Conversation

@pacoxu
Copy link
Contributor

@pacoxu pacoxu commented May 30, 2022

Signed-off-by: Paco Xu paco.xu@daocloud.io

containerd git:(add-metrics-scheduler) ✗ git status
位于分支 add-metrics-scheduler
您的分支与上游分支 'origin/add-metrics-scheduler' 一致。

未跟踪的文件:
  （使用 "git add <文件>..." 以包含要提交的内容）
        .vscode/

提交为空，但是存在尚未跟踪的文件（使用 "git add" 建立跟踪）
➜  containerd git:(add-metrics-scheduler) ✗ ls .vscode 
configurationCache.log dryrun.log             settings.json          targets.log

@pacoxu
add Vscode dir to git ignore
17ac7d0 
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@k8s-ci-robot
Copy link

k8s-ci-robot commented May 30, 2022

Hi @pacoxu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fuweid
fuweid requested changes May 30, 2022
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is about your local development environment.
You can solve by global ignore settings.

$ touch ~/.gitignore
$ echo '.vscode/'  >> ~/.gitignore # or other file/dir
$ git config --global core. excludesfile ~/.gitignore

I don't think that we should add personal ignore files to any projects :)

@pacoxu
Copy link
Contributor Author

pacoxu commented May 31, 2022

Thanks for the clarification.

https://github.com/kubernetes/kubernetes/blob/7e3c98fd303359cb9f79dfc691da733a6ca2a6e3/.gitignore#L4-L17

@pacoxu pacoxu closed this May 31, 2022
@fuweid
Copy link
Member

fuweid commented May 31, 2022

Thanks for the clarification.

https://github.com/kubernetes/kubernetes/blob/7e3c98fd303359cb9f79dfc691da733a6ca2a6e3/.gitignore#L4-L17

thanks for the link. But the project ignores should focus on the output of build. I uses vscode and neovim-ccls with cache in local. Not fan to add every cache or temp files to any using projects.

@mikebrow
Copy link
Member

mikebrow commented May 31, 2022 •
edited
Loading

nod.. been there pushed the "extra" git ignore for vsc .. got my commit rejected.. maybe we should figure out why vsc is creating a file in the wrong place.

@fuweid fuweid mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuweid fuweid fuweid requested changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pacoxu @k8s-ci-robot @fuweid @mikebrow