CRI: cleanup cri/store package #6993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
kzys
approved these changes
May 26, 2022
estesp
reviewed
May 27, 2022
estesp
approved these changes
May 27, 2022
Member
estesp
left a comment
There was a problem hiding this comment.
LGTM with one nit about extra word in error message
mikebrow
reviewed
May 27, 2022
Member
mikebrow
left a comment
There was a problem hiding this comment.
looks good just the nit on the error msg
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Member
|
@mikebrow ptal; looks like your comment was addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move out some code from
cri/storepackage:referencepackagetrunkindex(a general 'index tree') topkg/Signed-off-by: Maksym Pavlenko pavlenko.maksym@gmail.com