check for duplicate nspath possibilities#6806
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Apr 14, 2022
Merged
Conversation
|
Build succeeded.
|
fuweid
reviewed
Apr 14, 2022
5507e37 to
a9e06a3
Compare
|
Build succeeded.
|
fuweid
reviewed
Apr 14, 2022
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
a9e06a3 to
147f0a7
Compare
|
Build succeeded.
|
dmcgowan
approved these changes
Apr 14, 2022
This was referenced Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing a flake in k8s e2e summary test that should not happen where network stats do not exist as reported by cadvisor. While debugging ran into docs indicating rand.Reader.Read may return < n bytes, may return 0 with no err. .. Per suggestion from @fuweid moved to rand.Read()... While in here should not hurt to check if the "random" generated namespace already exists, because in use or because did not get torn down. If the later and still exists should do further investigation for tearing it down.
https://github.com/kubernetes/kubernetes/issues/109082Signed-off-by: Mike Brown brownwm@us.ibm.com