Upgrade golangci-lint and its GitHub Action#6666
Conversation
TBBle
left a comment
There was a problem hiding this comment.
Seems like a good change to me. A quick check of the golangci-lint release notes suggests staticcheck wasn't changed and nothing else jumped out at me that would help with the flakiness, but as long as it passes, being on a more-recent version seems good anyway.
.github/workflows/ci.yml
Outdated
| version: v1.42.0 | ||
| version: v1.44.2 | ||
| args: --timeout=5m | ||
| skip-go-installation: true |
There was a problem hiding this comment.
v3 of the action made this implicit and dropped the flag, so this is generating a warning.
There was a problem hiding this comment.
Good catch! Fixed in the last revision.
The GitHub Action is unstable especially on Windows (see containerd#6618). This change may not address the issue itself, but using the latest version makes reporting the upstream the issue easier. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
|
Build succeeded.
|
Are you having trouble with Staticcheck? |
|
Still no luck. but that is a known issue (#6652) and upgrading golangci-lint wouldn't affect this behavior. |
|
Based on some initial investigation, I think this is an issue with the caching golangci-lint-action is doing, which uses https://github.com/actions/cache. It's manifesting as a weird issue with staticcheck, but I don't think staticcheck is doing anything wrong, and I haven't been able to repro the issue locally. I'll share more details on the caching as I learn more. |
The GitHub Action is unstable especially on Windows (see #6618).
This change may not address the issue itself, but using the latest
version makes reporting the upstream the issue easier.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com