Skip to content

[release/1.5 backport] snapshot/devmapper: log exported methods correctly#5764

Merged
dmcgowan merged 1 commit intocontainerd:release/1.5from
thaJeztah:1.5_backport_dm_log
Jul 21, 2021
Merged

[release/1.5 backport] snapshot/devmapper: log exported methods correctly#5764
dmcgowan merged 1 commit intocontainerd:release/1.5from
thaJeztah:1.5_backport_dm_log

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

backport of #5655

  • View was somehow logging itself as "prepare"
  • Cleanup should have its debug log as like other exported methods

- View was somehow logging itself as "prepare"
- Cleanup should have its debug log as like other exported methods

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
(cherry picked from commit 03ee450)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

@kzys @AkihiroSuda PTAL

Same question for this as #5765 (comment); a bit unsure if this was needed for 1.4 as well (seems rather minimal, although overall looks "safe")

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 20, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 1c13c54 into containerd:release/1.5 Jul 21, 2021
@thaJeztah thaJeztah deleted the 1.5_backport_dm_log branch July 21, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants