Skip to content

[release/1.5] update runc to v1.0.1#5752

Merged
estesp merged 2 commits intocontainerd:release/1.5from
AkihiroSuda:runc-v1.0.1-15
Jul 20, 2021
Merged

[release/1.5] update runc to v1.0.1#5752
estesp merged 2 commits intocontainerd:release/1.5from
AkihiroSuda:runc-v1.0.1-15

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Jul 18, 2021 •
edited
Loading

Cherry-pick binary commit from #5751 but leave go.mod as-is. (EDIT: update libcontainer too to pull opencontainers/runc#3079 in)

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jul 18, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 18, 2021

Build succeeded.

@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Jul 18, 2021

Failure is unrelated


=== FAIL: . TestUserNamespaces/ReadonlyRootFS (0.21s)
    log_hook.go:40: time="2021-07-18T11:38:50.184925509Z" level=debug msg=resolving func="docker.(*dockerResolver).Resolve" file="/home/runner/work/containerd/containerd/src/github.com/containerd/containerd/remotes/docker/resolver.go:279" host=mirror.gcr.io
    log_hook.go:40: time="2021-07-18T11:38:50.185627014Z" level=debug msg="do request" func="docker.(*request).do" file="/home/runner/work/containerd/containerd/src/github.com/containerd/containerd/remotes/docker/resolver.go:538" host=mirror.gcr.io request.header.accept="application/vnd.docker.distribution.manifest.v2+json, application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.manifest.v1+json, application/vnd.oci.image.index.v1+json, */*" request.header.user-agent=containerd/1.5.3+unknown request.method=HEAD url="https://mirror.gcr.io/v2/library/alpine/manifests/3.13"
    log_hook.go:40: time="2021-07-18T11:38:50.342785103Z" level=debug msg="fetch response received" func="docker.(*request).do" file="/home/runner/work/containerd/containerd/src/github.com/containerd/containerd/remotes/docker/resolver.go:546" host=mirror.gcr.io response.header.accept-ranges=none response.header.alt-svc="h3=\":443\"; ma=2592000,h3-29=\":443\"; ma=2592000,h3-T051=\":443\"; ma=2592000,h3-Q050=\":443\"; ma=2592000,h3-Q046=\":443\"; ma=2592000,h3-Q043=\":443\"; ma=2592000,quic=\":443\"; ma=2592000; v=\"46,43\"" response.header.cache-control=private response.header.content-type=application/json response.header.date="Sun, 18 Jul 2021 11:38:50 GMT" response.header.docker-distribution-api-version=registry/2.0 response.header.server="Docker Registry" response.header.vary=Accept-Encoding response.header.x-frame-options=SAMEORIGIN response.header.x-xss-protection=0 response.status="404 Not Found" url="https://mirror.gcr.io/v2/library/alpine/manifests/3.13"
    log_hook.go:40: time="2021-07-18T11:38:50.343815410Z" level=info msg="trying next host - response was http.StatusNotFound" func="docker.(*dockerResolver).Resolve" file="/home/runner/work/containerd/containerd/src/github.com/containerd/containerd/remotes/docker/resolver.go:296" host=mirror.gcr.io
    container_linux_test.go:1603: failed to resolve reference "mirror.gcr.io/library/alpine:3.13": mirror.gcr.io/library/alpine:3.13: not found
    --- FAIL: TestUserNamespaces/ReadonlyRootFS (0.21s)

thaJeztah
thaJeztah approved these changes Jul 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda changed the title [release/1.5] update runc binary to v1.0.1 [release/1.5] update runc to v1.0.1 Jul 19, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 19, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 19, 2021

Build succeeded.

@AkihiroSuda AkihiroSuda marked this pull request as ready for review July 19, 2021 18:42
@ReillyBrogan
Copy link
Copy Markdown

ReillyBrogan commented Jul 19, 2021

It looks like runc 1.0.0 has a few kubernetes defects that are fixed by 1.0.1. Perhaps once this is merged we could get a new release cut so that there's a release with all the security improvements AND no kubernetes regressions?

@AkihiroSuda
update runc binary to v1.0.1
6807d07 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 43e0594)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
go.mod: runc v1.0.1
d2cb994 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 20, 2021

Build succeeded.

estesp
estesp approved these changes Jul 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit c355601 into containerd:release/1.5 Jul 20, 2021
This was referenced Jul 20, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AkihiroSuda @k8s-ci-robot @ReillyBrogan @estesp @thaJeztah