[release/1.4] Update Go to 1.15.13#5664
Conversation
go1.15.13 (released 2021-06-03) includes security fixes to the archive/zip, math/big, net, and net/http/httputil packages, as well as bug fixes to the linker, the go command, and the math/big and net/http packages. See the Go 1.15.13 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.15.13+label%3ACherryPickApproved go1.15.12 (released 2021-05-06) includes a security fix to the net/http package, as well as bug fixes to the runtime, the compiler, and the archive/zip, time, and syscall packages. See the Go 1.15.12 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.15.12+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
LGTM
noting that our go.mod minimum version is currently set to go 1.16
https://github.com/containerd/containerd/blob/main/go.mod#L3
Yeah, that's the main branch, this is the release/1.4 branch, which is not yet using go modules. Overall, I think we should be "conservative" setting that to "latest" versions if not needed. Go currently only treats it as a warning, but it may at some point refuse to use the go module with other go versions (which may not be needed if the package someone uses does not require latest "go" version) |
|
Is someone able to kick CI? (not sure why Windows failed, but probably just flaky) |
nod.. With respect to testing we should probably be presuming that those vendoring/building containerd will try to run on pretty much anything from 1.13 and up. https://github.com/containerd/containerd/blob/main/BUILDING.md#build-requirements same on main and release/1.4. |
go1.15.13 (released 2021-06-03) includes security fixes to the archive/zip, math/big,
net, and net/http/httputil packages, as well as bug fixes to the linker, the go
command, and the math/big and net/http packages. See the Go 1.15.13 milestone on
the issue tracker for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.15.13+label%3ACherryPickApproved
go1.15.12 (released 2021-05-06) includes a security fix to the net/http package,
as well as bug fixes to the runtime, the compiler, and the archive/zip, time,
and syscall packages. See the Go 1.15.12 milestone on the issue tracker for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.15.12+label%3ACherryPickApproved