Skip to content

update runc binary & library to v1.0.0 GA#5552

Merged
dims merged 2 commits intocontainerd:mainfrom
AkihiroSuda:runc-v1.0.0
Jun 22, 2021
Merged

update runc binary & library to v1.0.0 GA#5552
dims merged 2 commits intocontainerd:mainfrom
AkihiroSuda:runc-v1.0.0

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Jun 1, 2021

@AkihiroSuda
Copy link
Copy Markdown
Member Author

/retest

@AkihiroSuda AkihiroSuda force-pushed the runc-v1.0.0 branch 2 times, most recently from e469fee to f2b4e67 Compare June 17, 2021 08:16
@theopenlab-ci

This comment has been minimized.

@containerd containerd deleted a comment from theopenlab-ci bot Jun 17, 2021
@containerd containerd deleted a comment from theopenlab-ci bot Jun 17, 2021
@AkihiroSuda
Copy link
Copy Markdown
Member Author

/ok-to-test

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title [DNM] update runc binary to v1.0.0 GA update runc binary to v1.0.0 GA Jun 22, 2021
@AkihiroSuda AkihiroSuda marked this pull request as ready for review June 22, 2021 06:09
@AkihiroSuda AkihiroSuda requested a review from dmcgowan June 22, 2021 06:09
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 22, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title update runc binary to v1.0.0 GA update runc binary & library to v1.0.0 GA Jun 22, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 22, 2021

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member

I think we only want to cherry-pick the binary update, not the vendoring? should we keep the go.mod changes separate (there's already #5635)

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims dims mentioned this pull request Jun 22, 2021
Copy link
Copy Markdown
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims
Copy link
Copy Markdown
Member

dims commented Jun 22, 2021

/ok-to-test

@dims dims merged commit f913a42 into containerd:main Jun 22, 2021
@iyashu
Copy link
Copy Markdown

iyashu commented Jun 23, 2021

@dims @AkihiroSuda are there any immediate plans to create a new containerd release with above runc dependency?

@dims
Copy link
Copy Markdown
Member

dims commented Jun 23, 2021

@iyashu 1.6 is possibly the first version that will have this v1.0.0 runc (see discussion in #5638 (review))

@thaJeztah
Copy link
Copy Markdown
Member

I think the runc binary can be updated to v1.0.0 for v1.5.x (#5638 (review) is about the vendored code, which doesn't have to be updated)

@thaJeztah thaJeztah added cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch and removed cherry-pick/1.4.x labels Jun 24, 2021
@thaJeztah
Copy link
Copy Markdown
Member

Opened #5649 and #5650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch impact/changelog ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants