Runtime cleanup #5368
Merged
Runtime cleanup #5368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
To ease code readability Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
|
Build succeeded.
|
Test Results 13 files 219 suites 47m 26s ⏱️ Results for commit b83d04f. |
kzys
reviewed
Apr 15, 2021
| // Tasks returns all the current tasks for the runtime. | ||
| // Any container runs at most one task at a time. | ||
| Tasks(context.Context, bool) ([]Task, error) | ||
| Tasks(ctx context.Context, all bool) ([]Task, error) |
Member
There was a problem hiding this comment.
Naming the flag all is confusing since Tasks() returns all tasks regardless of the flag. Seems the flag means "from all namespaces".
macias1111
approved these changes
Apr 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor runtime changes:
ShimStartparams into a separate structureshim.StartOpts. This will make easier adding new options and keep backward compatibility. For instance, turns out we pass shim runtime options via Stdin, but don't really use those in the shim itself. I think we should expose this option in 1.6.