Skip to content

Add support for NetBSD#4579

Merged
estesp merged 1 commit intocontainerd:masterfrom
iamleot:netbsd-support
Sep 22, 2020
Merged

Add support for NetBSD#4579
estesp merged 1 commit intocontainerd:masterfrom
iamleot:netbsd-support

Conversation

@iamleot
Copy link
Copy Markdown
Contributor

@iamleot iamleot commented Sep 22, 2020

I have tested that by building and trying - successfully! (at least for
basic testing) - the Docker CLI on NetBSD/amd64 (and only a couple of
patches are needed for
containerd/console that I will share in
the next minutes).

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Sep 22, 2020

Hi @iamleot. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamleot iamleot mentioned this pull request Sep 22, 2020
Merged
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 22, 2020

Build succeeded.

@iamleot
Copy link
Copy Markdown
Contributor Author

iamleot commented Sep 22, 2020

Unfortunately I do not understand the two tests failing, to directly quote them here to hopefully save some time...
CI / Linters (macos-10.15) fails on Make check step due:

GOGC=75 golangci-lint run
##[error]content/local/store_unix.go:1: File is not `goimports`-ed (goimports)
// +build linux solaris darwin freebsd netbsd 
make: *** [check] Error 1
##[error]Process completed with exit code 2.

CI / Project Checks fails on DCO step due:

+ '[' -z https://api.github.com/repos/containerd/containerd/pulls/4579/commits ']'
++ curl https://api.github.com/repos/containerd/containerd/pulls/4579/commits
++ jq -r '.[0].parents[0].sha + "..HEAD"'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  4  3855    4   185    0     0   1225      0  0:00:03 --:--:--  0:00:03  1217
100  3855  100  3855    0     0  25529      0 --:--:-- --:--:-- --:--:-- 25361
+ DCO_RANGE=534be84c5dfd78031603d2afde90098cc4347c6b..HEAD
+ ../project/script/validate/dco
/home/runner/work/containerd/containerd/bin/git-validation
 c41aae8 - FAIL - has whitespace errors. See `git show --check c41aae8c609c0cf65c08658830c29b9f71fba503`.
 2baaf12 - FAIL - has whitespace errors. See `git show --check 2baaf123553b030d17a707b5eb4e4cb7efd1b984`.
2 commits to fix
##[error]Process completed with exit code 1.

If these are related to this commit shared in this PR any possible help or further explanation on what's going on is more than welcomed!

Thank you!

estesp
estesp reviewed Sep 22, 2020
View reviewed changes
@iamleot
Add support for NetBSD
4c47fe0 
Signed-off-by: Leonardo Taccari <leot@NetBSD.org>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 22, 2020

Build succeeded.

estesp
estesp approved these changes Sep 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 4e5ce76 into containerd:master Sep 22, 2020
@iamleot
Copy link
Copy Markdown
Contributor Author

iamleot commented Sep 23, 2020

Thank you @mxpv and @estesp for the review and for quickly merging it!

@thaJeztah thaJeztah mentioned this pull request Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iamleot @k8s-ci-robot @mxpv @estesp