Conversation
|
Build succeeded.
|
remotes/docker/pusher.go
Outdated
There was a problem hiding this comment.
How do we feel about the readall here for an unexpected response? This could be tricky as we could get a large response and OOM the daemon/machine.
I think for this to be secure, we need to have some type of upper bound on this.
There was a problem hiding this comment.
I am not sure myself, this is just what I had, I was wondering if this could be conditioned on the log-level somehow, but even then it could be too expensive...
There was a problem hiding this comment.
given this is just to log, seems 64kb is way more than enough? like this maybe: https://github.com/containerd/containerd/blob/master/remotes/docker/auth/fetch.go#L55
855825c to
65aea85
Compare
|
@estesp @crosbymichael I figured reusing |
c455e6b to
68aa7f6
Compare
This accomplishes a few long-standing TODO items, but also helps users in showing exact registry error messages Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
68aa7f6 to
2de5506
Compare
|
Build succeeded.
|
|
Thanks @crosbymichael! Looks like CI is failing, am I right that it's unrelated to the change? https://github.com/containerd/containerd/pull/4523/checks?check_run_id=1067134149 |
|
thanks a lot @estesp! |
This accomplishes a few long-standing TODO items, but also helps users in showing exact registry error messages.
I was stuck for a while trying to debug docker/buildx#300 without this, not realising the responses had pretty clear error messages attached.