Skip to content

[release/1.3] Enable GH Actions for release/1.3 branch#4280

Merged
AkihiroSuda merged 3 commits intocontainerd:release/1.3from
estesp:enable-actions-1.3
May 21, 2020
Merged

[release/1.3] Enable GH Actions for release/1.3 branch#4280
AkihiroSuda merged 3 commits intocontainerd:release/1.3from
estesp:enable-actions-1.3

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented May 21, 2020

Configuration that matches the Travis setup for release/1.3.

Copied script changes from master for actions; lint fix in resolver test and updated to golangci-lint version from master, as well as matched 3m timeout for linting from master.

Cherry picked 4756258 from master to fix lint issue on Windows (unused var).

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

@estesp estesp force-pushed the enable-actions-1.3 branch 3 times, most recently from 18067cc to 3393d59 Compare May 21, 2020 14:39
Configuration that matches the Travis setup for release/1.3.
Backported test fix for golangci-lint check; synced timeout for lint
with master.

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
@estesp estesp force-pushed the enable-actions-1.3 branch from 3393d59 to 55b88c4 Compare May 21, 2020 14:57
@containerd containerd deleted a comment from theopenlab-ci bot May 21, 2020
@containerd containerd deleted a comment from theopenlab-ci bot May 21, 2020
@containerd containerd deleted a comment from theopenlab-ci bot May 21, 2020
@containerd containerd deleted a comment from theopenlab-ci bot May 21, 2020
@containerd containerd deleted a comment from theopenlab-ci bot May 21, 2020
@estesp estesp changed the title Enable GH Actions for release/1.3 [release/1.3] Enable GH Actions for release/1.3 branch May 21, 2020
thaJeztah and others added 2 commits May 21, 2020 12:14
This was added in 40d898a, but
doesn't appear to be used.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
Unlike master, release/1.3 still has the socat dependency from CRI.

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
@estesp estesp force-pushed the enable-actions-1.3 branch from 2e7282c to c77ae0e Compare May 21, 2020 16:15
@containerd containerd deleted a comment from theopenlab-ci bot May 21, 2020
@containerd containerd deleted a comment from theopenlab-ci bot May 21, 2020
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan
Copy link
Copy Markdown
Member

Travis will be disabled in follow up?

@AkihiroSuda AkihiroSuda merged commit 3943a53 into containerd:release/1.3 May 21, 2020
@estesp estesp deleted the enable-actions-1.3 branch May 21, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants