runtime: ignore ttrpc closed error#4198
Merged
estesp merged 2 commits intocontainerd:masterfrom Apr 20, 2020
Merged
Conversation
fuweid
commented
Apr 20, 2020
vendor.conf
Outdated
Member
Author
There was a problem hiding this comment.
maybe we can make new release for ttrpc when release containerd v1.4
|
Build succeeded.
|
e7e0073 to
6a686c6
Compare
|
Build succeeded.
|
cpuguy83
reviewed
Apr 20, 2020
runtime/v2/shim.go
Outdated
For some reason, shimv2 process doesn't exist. The ttrpc doesn't detect the connection closed by server until delete task. For this case, we should ignore the ttrpc.ErrClosed and let task manager handle the cleanup. Signed-off-by: Wei Fu <fuweid89@gmail.com>
Signed-off-by: Wei Fu <fuweid89@gmail.com>
6a686c6 to
126e497
Compare
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, shimv2 process doesn't exist. The ttrpc doesn't detect
the connection closed by server until delete task. For this case, we
should ignore the ttrpc.ErrClosed and let task manager handle the
cleanup.
And update ttrpc vendor with 6e416eafd26e6e738df716b21d421d5b59702bb4 to have better ErrClosed filter.
Signed-off-by: Wei Fu fuweid89@gmail.com