script: use github.com/kubernetes-sigs/cri-tools directly#4034
Merged
estesp merged 1 commit intocontainerd:masterfrom Feb 17, 2020
Merged
script: use github.com/kubernetes-sigs/cri-tools directly#4034estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
When we call `go get -d -v github.com/kubernetes-incubator/cri-tools/...` which repos has been moved to `github.com/kubernetes-sigs/cri-tools`, `go get` will create package `github.com/kubernetes-sigs/cri-tools`. ``` go get -d -v github.com/kubernetes-incubator/cri-tools/... github.com/kubernetes-incubator/cri-tools (download) github.com/kubernetes-sigs/cri-tools (download) ``` According to old version of `github.com/kubernetes-incubator/cri-tools` Makefile, if there is no `github.com/kubernetes-sigs/cri-tools` package, it will create softlink self to `github.com/kubernetes-sigs/cri-tools`. But `go get` will create `github.com/kubernetes-sigs/cri-tools` and there is no softlink. Therefore, the critools are always latest one, not specific version. So, use `github.com/kubernetes-sigs/cri-tools` will be better and save traffic from `go get`. Signed-off-by: Wei Fu <fuweid89@gmail.com>
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we call
go get -d -v github.com/kubernetes-incubator/cri-tools/...which repos has beenmoved to
github.com/kubernetes-sigs/cri-tools,go getwill createpackage
github.com/kubernetes-sigs/cri-tools.According to old version of
github.com/kubernetes-incubator/cri-toolsMakefile, if there is no
github.com/kubernetes-sigs/cri-toolspackage,it will create softlink self to
github.com/kubernetes-sigs/cri-tools.But
go getwill creategithub.com/kubernetes-sigs/cri-toolsandthere is no softlink. Therefore, the critools are always latest one, not
specific version.
So, use
github.com/kubernetes-sigs/cri-toolswill be better and savetraffic from
go get.Signed-off-by: Wei Fu fuweid89@gmail.com