v2: Fix missing ns when openShimLog on windows#3929
Merged
fuweid merged 1 commit intocontainerd:masterfrom Jan 6, 2020
Merged
Conversation
|
Build succeeded.
|
586c619 to
a87118c
Compare
|
Build succeeded.
|
a87118c to
5c059dd
Compare
|
Build succeeded.
|
5c059dd to
aef1a8f
Compare
|
Build succeeded.
|
aef1a8f to
6a22539
Compare
|
Build succeeded.
|
6a22539 to
12ab4c0
Compare
|
Build succeeded.
|
Related to containerd#3921 (comment) Signed-off-by: Li Yuxuan <liyuxuan04@baidu.com>
12ab4c0 to
1fb1d93
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3929 +/- ##
==========================================
- Coverage 42.42% 42.42% -0.01%
==========================================
Files 130 130
Lines 14710 14711 +1
==========================================
Hits 6241 6241
- Misses 7548 7549 +1
Partials 921 921
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Jan 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3921 (comment)
/cc @TBBle
Signed-off-by: Li Yuxuan liyuxuan04@baidu.com