Skip to content

Temporarily disable criu tests in Travis CI#3898

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
estesp:test-5.0-kernel-ci
Dec 19, 2019
Merged

Temporarily disable criu tests in Travis CI#3898
AkihiroSuda merged 1 commit intocontainerd:masterfrom
estesp:test-5.0-kernel-ci

Conversation

@estesp
Copy link
Member

@estesp estesp commented Dec 18, 2019 •
edited
Loading

Until we resolve what's wrong with the criu tests with the update to the 5.0.0 kernel in Travis. Also updates installed criu to latest version so any bug reports will be against latest release.

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

@estesp estesp force-pushed the test-5.0-kernel-ci branch 2 times, most recently from 371d379 to 88445c3 Compare December 19, 2019 03:27
@estesp estesp changed the title TEST: Check criu tests against new 5.0.0 travis kernel Temporarily disable criu tests in Travis CI Dec 19, 2019
@estesp
Disable criu tests in Travis CI
02dcf38 
Temporarily disable criu tests until the 5.0.0 CI kernel issue is
resolved. Also update criu to v3.13

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
@estesp estesp force-pushed the test-5.0-kernel-ci branch from 88445c3 to 02dcf38 Compare December 19, 2019 05:06
@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 19, 2019

Build succeeded.

@estesp estesp marked this pull request as ready for review December 19, 2019 05:25
@containerd containerd deleted a comment from theopenlab-ci bot Dec 19, 2019
@containerd containerd deleted a comment from theopenlab-ci bot Dec 19, 2019
@containerd containerd deleted a comment from theopenlab-ci bot Dec 19, 2019
@estesp
Copy link
Member Author

estesp commented Dec 19, 2019

@containerd/containerd-reviewers @containerd/containerd-maintainers this is ready for review; and then all the broken CI PRs can rebase to disable criu testing in Travis for now.

@fuweid
Copy link
Member

fuweid commented Dec 19, 2019 

choco install -y mingw --version 5.3.0
Chocolatey v0.10.15
Installing the following packages:
mingw
By installing you accept licenses for the packages.
[NuGet] The operation has timed out
mingw not installed. The package was not found with the source(s) listed.
 Source(s): 'https://chocolatey.org/api/v2/'
 NOTE: When you specify explicit sources, it overrides default sources.
If the package version is a prerelease and you didn't specify `--pre`,
 the package may not be found.
Version was specified as '5.3.0'. It is possible that version 
 does not exist for 'mingw' at the source specified.
Please see https://chocolatey.org/docs/troubleshooting for more 
 assistance.
Chocolatey installed 0/1 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Failures
 - mingw - mingw not installed. The package was not found with the source(s) listed.
 Source(s): 'https://chocolatey.org/api/v2/'
 NOTE: When you specify explicit sources, it overrides default sources.
If the package version is a prerelease and you didn't specify `--pre`,
 the package may not be found.
Version was specified as '5.3.0'. It is possible that version 
 does not exist for 'mingw' at the source specified.
Please see https://chocolatey.org/docs/troubleshooting for more 
 assistance.

Maybe we can change other version?

fuweid
fuweid approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://chocolatey.org/packages/mingw/5.3.0 it is still available. Windows CI has package server issue. It is flaky.

@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #3898 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3898   +/-   ##
=======================================
  Coverage   42.47%   42.47%           
=======================================
  Files         130      130           
  Lines       14716    14716           
=======================================
  Hits         6251     6251           
  Misses       7544     7544           
  Partials      921      921
Flag Coverage Δ
#linux 45.86% <ø> (ø) ⬆️
#windows 38% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b5581c...02dcf38. Read the comment docs.

@AkihiroSuda AkihiroSuda merged commit 05bc0a1 into containerd:master Dec 19, 2019
@estesp estesp deleted the test-5.0-kernel-ci branch December 19, 2019 14:40
This was referenced Dec 20, 2019
Merged
Merged
@AkihiroSuda AkihiroSuda mentioned this pull request Dec 31, 2019
Closed
@adrianreber
Copy link
Contributor

adrianreber commented Jan 6, 2020

We have seen also test failures in upstream CRIU using Travis. I opened

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1857257

@adrianreber adrianreber mentioned this pull request Jan 6, 2020
Closed
@estesp estesp mentioned this pull request Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@estesp @fuweid @codecov-io @adrianreber @AkihiroSuda