[release 1.2] Fix cleanup error on content client test#3856
Merged
dmcgowan merged 1 commit intocontainerd:release/1.2from Nov 27, 2019
Merged
[release 1.2] Fix cleanup error on content client test#3856dmcgowan merged 1 commit intocontainerd:release/1.2from
dmcgowan merged 1 commit intocontainerd:release/1.2from
Conversation
A race occurs today where the cleanup runs after the lease has been deleted, making all the content and statuses eligible for collection during the cleanup. There is a case where a status could be listed but removed before the abort is called. In this case, abort will return a not found and the test cleanup should ignore it. Signed-off-by: Derek McGowan <derek@mcgstyle.net> (cherry picked from commit 8da4346) Signed-off-by: Wei Fu <fuweid89@gmail.com>
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3856 +/- ##
===============================================
- Coverage 47.87% 44.19% -3.68%
===============================================
Files 91 100 +9
Lines 8483 10847 +2364
===============================================
+ Hits 4061 4794 +733
- Misses 3688 5313 +1625
- Partials 734 740 +6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A race occurs today where the cleanup runs after the lease
has been deleted, making all the content and statuses
eligible for collection during the cleanup. There is a case
where a status could be listed but removed before the
abort is called. In this case, abort will return a not found
and the test cleanup should ignore it.
Signed-off-by: Derek McGowan derek@mcgstyle.net
(cherry picked from commit 8da4346)
Signed-off-by: Wei Fu fuweid89@gmail.com
cherry-pick #3853