Add --log-file flag for windows service.#3831
Add --log-file flag for windows service.#3831crosbymichael merged 1 commit intocontainerd:masterfrom
--log-file flag for windows service.#3831Conversation
|
Build succeeded.
|
|
The test failure is another occurrence of #3787. Not sure why I can't trigger travis rerun now. |
There was a problem hiding this comment.
I think GlobalString will return "" if the param is not set, so you can probably just write logFileFlag = context.GlobalString("log-file").
There was a problem hiding this comment.
Done. Also enhanced the service name flag handling a little bit.
|
Is there any desire to support a |
|
@kevpar I think only windows is sufficient. On linux people usually use journald or IO redirection directly. :) |
Signed-off-by: Lantao Liu <lantaol@google.com>
d955939 to
0bb48ae
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3831 +/- ##
==========================================
+ Coverage 41.98% 41.99% +0.01%
==========================================
Files 130 130
Lines 14577 14577
==========================================
+ Hits 6120 6122 +2
+ Misses 7543 7542 -1
+ Partials 914 913 -1
Continue to review full report at Codecov.
|
|
LGTM |
|
Requesting 1.3.X backport with #3840 |
Event and tracing are good, but the traditional log file is also very useful, e.g. I can't find an ETW plugin for fluentd yet.
--log-fileis what we are doing for kubelet and kube-proxy on windows, too. It is optional, old behavior is kept if the flag is not specified.@jterry75
Signed-off-by: Lantao Liu lantaol@google.com