Skip to content

Windows process shim installer#3790

Merged
mxpv merged 1 commit intocontainerd:masterfrom
ameyag:windows-shim-install
Oct 31, 2019
Merged

Windows process shim installer#3790
mxpv merged 1 commit intocontainerd:masterfrom
ameyag:windows-shim-install

Conversation

@ameyag
Copy link
Copy Markdown
Contributor

@ameyag ameyag commented Oct 30, 2019

Install windows shim dependencies in containerd managed opt directory.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 30, 2019

Build succeeded.

@ameyag ameyag force-pushed the windows-shim-install branch from 0b726c6 to 86a93f6 Compare October 30, 2019 15:40
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 30, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 30, 2019

Codecov Report

Merging #3790 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3790   +/-   ##
======================================
  Coverage      42%     42%           
======================================
  Files         131     131           
  Lines       14589   14589           
======================================
  Hits         6128    6128           
  Misses       7547    7547           
  Partials      914     914
Flag Coverage Δ
#linux 45.43% <ø> (ø) ⬆️
#windows 36.97% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 342ce3e...d21f0f1. Read the comment docs.

@ameyag ameyag force-pushed the windows-shim-install branch from 86a93f6 to b81d853 Compare October 30, 2019 16:34
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 30, 2019

Build succeeded.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Signed-off-by: Ameya Gawde <ameya.gawde@docker.com>
@ameyag ameyag force-pushed the windows-shim-install branch from b81d853 to d21f0f1 Compare October 30, 2019 23:23
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 30, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit 257a749 into containerd:master Oct 31, 2019
@ameyag ameyag deleted the windows-shim-install branch November 1, 2019 00:06
@ameyag ameyag restored the windows-shim-install branch November 20, 2019 18:22
@ameyag ameyag deleted the windows-shim-install branch November 20, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants