apply: use naive applier when running in UserNS#3763
Merged
estesp merged 1 commit intocontainerd:masterfrom Oct 24, 2019
Merged
apply: use naive applier when running in UserNS#3763estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
This was referenced Oct 19, 2019
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3763 +/- ##
==========================================
- Coverage 41.98% 41.96% -0.02%
==========================================
Files 131 131
Lines 14536 14538 +2
==========================================
- Hits 6103 6101 -2
- Misses 7525 7528 +3
- Partials 908 909 +1
Continue to review full report at Codecov.
|
dmcgowan
reviewed
Oct 22, 2019
bdca148 to
3cd0d1f
Compare
|
Build succeeded.
|
3cd0d1f to
6778c5e
Compare
|
Build succeeded.
|
dmcgowan
reviewed
Oct 23, 2019
`OverlayConvertWhiteout` calls `mknod c 0 0` which is not allowed when running in a user namespace, even in Ubuntu kernel. Although there is an alternative hacky way to create whiteouts without calling mknod as Moby `overlay2` actually does(see containerd#3762), let's use naive applier when running in UserNS and call it a day. Close containerd#3762 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
6778c5e to
c224edc
Compare
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OverlayConvertWhiteoutcallsmknod c 0 0which is not allowed whenrunning in a user namespace, even in Ubuntu kernel.
Although there is an alternative hacky way to create whiteouts without
calling mknod as Moby
overlay2actually does(see #3762), let's usenaive applier when running in UserNS and call it a day.
Close #3762
Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp