runtime: only check killall for init process#3559
Merged
estesp merged 1 commit intocontainerd:masterfrom Aug 20, 2019
Merged
Conversation
When containerd-shim does reaper, the most processes are not init process. Since json.Decode consumes more CPU resource, we should check killall option for init process only. Signed-off-by: Wei Fu <fuweid89@gmail.com>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3559 +/- ##
=======================================
Coverage 42.19% 42.19%
=======================================
Files 127 127
Lines 13905 13905
=======================================
Hits 5867 5867
Misses 7152 7152
Partials 886 886
Continue to review full report at Codecov.
|
Member
|
LGTM |
Member
|
@fuweid LGTM. Thanks for investigating this! This makes a lot of sense to me. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When containerd-shim does reaper, the most processes are not init
process. Since json.Decode consumes more CPU resource, we should check
killall option for init process only.
Signed-off-by: Wei Fu fuweid89@gmail.com
link to #3540 (comment)