Add direct unpack support for overlay#3528
Merged
crosbymichael merged 3 commits intocontainerd:masterfrom Aug 19, 2019
Merged
Conversation
|
Build succeeded.
|
d5c005b to
cb355b5
Compare
|
Build succeeded.
|
780bfe2 to
6ec9330
Compare
|
Build succeeded.
|
Signed-off-by: Lantao Liu <lantaol@google.com>
6ec9330 to
cd9c404
Compare
|
Build succeeded.
|
cd9c404 to
b211cc7
Compare
|
Build succeeded.
|
Pulls in copy and fstest changes Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
b211cc7 to
bcc4a14
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3528 +/- ##
==========================================
- Coverage 44.94% 44.89% -0.05%
==========================================
Files 115 118 +3
Lines 12790 12991 +201
==========================================
+ Hits 5748 5832 +84
- Misses 6170 6274 +104
- Partials 872 885 +13
Continue to review full report at Codecov.
|
Member
Author
|
Added overlay specific tests including ones to cover the case of copying up parent directory permission when excluded from tars. This is ready for review. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows unpacking an overlay filesystem without needing to first perform a mount. This is an optimization when using the overlay snapshotter (aufs snapshotter also supported). Handles missing parent directories in tars through doing a directory copy up rather than a simple mkdirall. Unified Windows parent layer functionality to have a single apply options structure for all platforms.
Creating as draft until I figure out what tests should be added for this case.