Update resolver to handle endpoint configuration #3400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jul 10, 2019
AkihiroSuda
reviewed
Jul 10, 2019
remotes/docker/resolver.go
Outdated
Member
Author
There was a problem hiding this comment.
The end result to the caller is the same, no manifest could be returned. Whether that is because it does not exist or it could not find a valid manifest won't make a difference.
AkihiroSuda
reviewed
Jul 10, 2019
fuweid
reviewed
Jul 10, 2019
06ce917 to
22625f4
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3400 +/- ##
==========================================
+ Coverage 45.05% 45.06% +0.01%
==========================================
Files 113 114 +1
Lines 12563 12739 +176
==========================================
+ Hits 5660 5741 +81
- Misses 6049 6131 +82
- Partials 854 867 +13
Continue to review full report at Codecov.
|
22625f4 to
06582cb
Compare
|
Build succeeded.
|
stevvooe
reviewed
Jul 16, 2019
stevvooe
reviewed
Jul 16, 2019
stevvooe
reviewed
Jul 16, 2019
stevvooe
reviewed
Jul 16, 2019
stevvooe
reviewed
Jul 16, 2019
Adds support for registry mirrors Adds support for multiple pull endpoints Adds capabilities to limit trust in public mirrors Fixes user agent header missing Signed-off-by: Derek McGowan <derek@mcgstyle.net>
06582cb to
0b29c9c
Compare
|
Build succeeded.
|
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for registry mirrors
Adds support for multiple pull endpoints
Adds registry capabilities to limit trust in public mirrors or avoid pushing to mirrors
Adds support for generic header addition